Use static name for package resource

... instead of using the actual package name. This helps users to
identify the resource name more easily.

Change-Id: Icc6a27685f3b3747b4e0562eb8066aa3cce5516c

manifests/api.pp

@@ -348,7 +348,7 @@ class glance::api(
   }
 
   if ( $glance::params::api_package_name != undef ) {
-    package { $::glance::params::api_package_name :
+    package { 'glance-api':
       ensure => $package_ensure,
       name   => $::glance::params::api_package_name,
       tag    => ['openstack', 'glance-package'],

manifests/init.pp

@@ -17,7 +17,7 @@ class glance(
   include glance::params
 
   if ( $glance::params::package_name != undef ) {
-    package { $::glance::params::package_name :
+    package { 'glance' :
       ensure => $package_ensure,
       name   => $::glance::params::package_name,
       tag    => ['openstack', 'glance-package'],

spec/classes/glance_api_spec.rb

@@ -534,6 +534,7 @@ describe 'glance::api' do
         end
         it { is_expected.to contain_package('glance-api').with(
           :ensure => package_ensure,
+          :name   => 'glance-api',
           :tag    => ['openstack', 'glance-package']
         )}
       end

spec/classes/glance_init_spec.rb

@@ -16,8 +16,9 @@ describe 'glance' do
         let(:params) do
           { :package_ensure => package_ensure }
         end
-        it { is_expected.to contain_package('openstack-glance').with(
+        it { is_expected.to contain_package('glance').with(
           :ensure => package_ensure,
+          :name   => 'openstack-glance',
           :tag    => ['openstack', 'glance-package']
         )}
       end

spec/classes/glance_spec.rb

@@ -23,8 +23,10 @@ describe 'glance' do
   shared_examples_for 'glance RedHat' do
     let(:params) { default_params }
 
-    it { is_expected.to contain_package('openstack-glance').with(
-        :tag => ['openstack', 'glance-package'],
+    it { is_expected.to contain_package('glance').with(
+      :ensure => 'present',
+      :name   => 'openstack-glance',
+      :tag    => ['openstack', 'glance-package'],
     )}
   end