openstack/puppet-glance
Code Issues Proposed changes

add access_log_env_var parameter to glance::wsgi::apache

Browse Source 
Change-Id: I1317560f1e3fcf999ef65f77f3a6e5d10ccc63fd
This commit is contained in:
Benedikt Trefzer 2025-01-02 21:51:42 +01:00
parent 7485fcb401
commit 71f0a2146c
3 changed files with 21 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
manifests/wsgi/apache.pp
View File

@ -80,6 +80,11 @@
# (Optional) The log format for the virtualhost.
# Defaults to undef.
#
# [*access_log_env_var*]
# (Optional) Specifies that only requests with particular
# environment variables be logged.
# Defaults to undef.
#
# [*error_log_file*]
# (Optional) The error log file name for the virtualhost.
# Defaults to undef.
@ -145,6 +150,7 @@ class glance::wsgi::apache (
$access_log_pipe = undef,
$access_log_syslog = undef,
$access_log_format = undef,
$access_log_env_var = undef,
$error_log_file = undef,
$error_log_pipe = undef,
$error_log_syslog = undef,
@ -192,6 +198,7 @@ class glance::wsgi::apache (
access_log_pipe => $access_log_pipe,
access_log_syslog => $access_log_syslog,
access_log_format => $access_log_format,
access_log_env_var => $access_log_env_var,
error_log_file => $error_log_file,
error_log_pipe => $error_log_pipe,
error_log_syslog => $error_log_syslog,

5
releasenotes/notes/access_log_env_var-faac53acf7960ab4.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
Add the ``access_log_env_var`` parameter to the ``glance::wsgi::apache``
class to allow filtering logs (eg. suppress healthecks)

15
spec/classes/glance_wsgi_apache_spec.rb
View File

@ -27,6 +27,7 @@ describe 'glance::wsgi::apache' do
:access_log_pipe => nil,
:access_log_syslog => nil,
:access_log_format => nil,
:access_log_env_var => nil,
:error_log_file => nil,
:error_log_pipe => nil,
:error_log_syslog => nil,
@ -80,16 +81,18 @@ describe 'glance::wsgi::apache' do
context 'with custom access logging' do
let :params do
{
:access_log_format => 'foo',
:access_log_syslog => 'syslog:local0',
:error_log_syslog => 'syslog:local1',
:access_log_format => 'foo',
:access_log_syslog => 'syslog:local0',
:error_log_syslog => 'syslog:local1',
:access_log_env_var => '!dontlog',
}
end
it { should contain_openstacklib__wsgi__apache('glance_wsgi').with(
:access_log_format => params[:access_log_format],
:access_log_syslog => params[:access_log_syslog],
:error_log_syslog => params[:error_log_syslog],
:access_log_format => params[:access_log_format],
:access_log_syslog => params[:access_log_syslog],
:error_log_syslog => params[:error_log_syslog],
:access_log_env_var => params[:access_log_env_var],
)}
end