spec: Add Unit Tests for glance paste_ini types/providers

Change-Id: Ia6688b80f983c76db5b076eafc842bfe2be4481b
Partial-bug: #1440401

spec/unit/provider/glance_api_paste_ini/ini_setting_spec.rb

@@ -0,0 +1,63 @@
+$LOAD_PATH.push(
+  File.join(
+    File.dirname(__FILE__),
+    '..',
+    '..',
+    '..',
+    'fixtures',
+    'modules',
+    'inifile',
+    'lib')
+)
+$LOAD_PATH.push(
+  File.join(
+    File.dirname(__FILE__),
+    '..',
+    '..',
+    '..',
+    'fixtures',
+    'modules',
+    'openstacklib',
+    'lib')
+)
+require 'spec_helper'
+provider_class = Puppet::Type.type(:glance_api_paste_ini).provider(:ini_setting)
+describe provider_class do
+
+  it 'should default to the default setting when no other one is specified' do
+    resource = Puppet::Type::Glance_api_paste_ini.new(
+      {:name => 'DEFAULT/foo', :value => 'bar'}
+    )
+    provider = provider_class.new(resource)
+    expect(provider.section).to eq('DEFAULT')
+    expect(provider.setting).to eq('foo')
+  end
+
+  it 'should allow setting to be set explicitly' do
+    resource = Puppet::Type::Glance_api_paste_ini.new(
+      {:name => 'dude/whoa', :value => 'bar'}
+    )
+    provider = provider_class.new(resource)
+    expect(provider.section).to eq('dude')
+    expect(provider.setting).to eq('whoa')
+  end
+
+  it 'should ensure absent when <SERVICE DEFAULT> is specified as a value' do
+    resource = Puppet::Type::Glance_api_paste_ini.new(
+      {:name => 'dude/foo', :value => '<SERVICE DEFAULT>'}
+    )
+    provider = provider_class.new(resource)
+    provider.exists?
+    expect(resource[:ensure]).to eq :absent
+  end
+
+  it 'should ensure absent when value matches ensure_absent_val' do
+    resource = Puppet::Type::Glance_api_paste_ini.new(
+      {:name => 'dude/foo', :value => 'foo', :ensure_absent_val => 'foo' }
+    )
+    provider = provider_class.new(resource)
+    provider.exists?
+    expect(resource[:ensure]).to eq :absent
+  end
+
+end

spec/unit/provider/glance_registry_paste_ini/ini_setting_spec.rb

@@ -0,0 +1,63 @@
+$LOAD_PATH.push(
+  File.join(
+    File.dirname(__FILE__),
+    '..',
+    '..',
+    '..',
+    'fixtures',
+    'modules',
+    'inifile',
+    'lib')
+)
+$LOAD_PATH.push(
+  File.join(
+    File.dirname(__FILE__),
+    '..',
+    '..',
+    '..',
+    'fixtures',
+    'modules',
+    'openstacklib',
+    'lib')
+)
+require 'spec_helper'
+provider_class = Puppet::Type.type(:glance_registry_paste_ini).provider(:ini_setting)
+describe provider_class do
+
+  it 'should default to the default setting when no other one is specified' do
+    resource = Puppet::Type::Glance_registry_paste_ini.new(
+      {:name => 'DEFAULT/foo', :value => 'bar'}
+    )
+    provider = provider_class.new(resource)
+    expect(provider.section).to eq('DEFAULT')
+    expect(provider.setting).to eq('foo')
+  end
+
+  it 'should allow setting to be set explicitly' do
+    resource = Puppet::Type::Glance_registry_paste_ini.new(
+      {:name => 'dude/whoa', :value => 'bar'}
+    )
+    provider = provider_class.new(resource)
+    expect(provider.section).to eq('dude')
+    expect(provider.setting).to eq('whoa')
+  end
+
+  it 'should ensure absent when <SERVICE DEFAULT> is specified as a value' do
+    resource = Puppet::Type::Glance_registry_paste_ini.new(
+      {:name => 'dude/foo', :value => '<SERVICE DEFAULT>'}
+    )
+    provider = provider_class.new(resource)
+    provider.exists?
+    expect(resource[:ensure]).to eq :absent
+  end
+
+  it 'should ensure absent when value matches ensure_absent_val' do
+    resource = Puppet::Type::Glance_registry_paste_ini.new(
+      {:name => 'dude/foo', :value => 'foo', :ensure_absent_val => 'foo' }
+    )
+    provider = provider_class.new(resource)
+    provider.exists?
+    expect(resource[:ensure]).to eq :absent
+  end
+
+end

spec/unit/type/glance_api_paste_ini_spec.rb

@@ -0,0 +1,87 @@
+require 'puppet'
+require 'puppet/type/glance_api_paste_ini'
+
+describe 'Puppet::Type.type(:glance_api_paste_ini)' do
+  before :each do
+    Puppet::Type.rmtype(:glance_api_paste_ini)
+    Facter.fact(:osfamily).stubs(:value).returns(platform_params[:osfamily])
+    @glance_api_paste_ini = Puppet::Type.type(:glance_api_paste_ini).new(:name => 'DEFAULT/foo', :value => 'bar')
+  end
+
+  shared_examples_for 'glance_api_paste_ini' do
+
+    it 'should require a name' do
+      expect {
+        Puppet::Type.type(:glance_api_paste_ini).new({})
+      }.to raise_error(Puppet::Error, 'Title or name must be provided')
+    end
+
+    it 'should not expect a name with whitespace' do
+      expect {
+        Puppet::Type.type(:glance_api_paste_ini).new(:name => 'f oo')
+      }.to raise_error(Puppet::Error, /Parameter name failed/)
+    end
+
+    it 'should fail when there is no section' do
+      expect {
+        Puppet::Type.type(:glance_api_paste_ini).new(:name => 'foo')
+      }.to raise_error(Puppet::Error, /Parameter name failed/)
+    end
+
+    it 'should not require a value when ensure is absent' do
+      Puppet::Type.type(:glance_api_paste_ini).new(:name => 'DEFAULT/foo', :ensure => :absent)
+    end
+
+    it 'should accept a valid value' do
+      @glance_api_paste_ini[:value] = 'bar'
+      expect(@glance_api_paste_ini[:value]).to eq('bar')
+    end
+
+    it 'should not accept a value with whitespace' do
+      @glance_api_paste_ini[:value] = 'b ar'
+      expect(@glance_api_paste_ini[:value]).to eq('b ar')
+    end
+
+    it 'should accept valid ensure values' do
+      @glance_api_paste_ini[:ensure] = :present
+      expect(@glance_api_paste_ini[:ensure]).to eq(:present)
+      @glance_api_paste_ini[:ensure] = :absent
+      expect(@glance_api_paste_ini[:ensure]).to eq(:absent)
+    end
+
+    it 'should not accept invalid ensure values' do
+      expect {
+        @glance_api_paste_ini[:ensure] = :latest
+      }.to raise_error(Puppet::Error, /Invalid value/)
+    end
+
+    it 'should autorequire the package that install the file' do
+      catalog = Puppet::Resource::Catalog.new
+      package = Puppet::Type.type(:package).new(:name => platform_params[:package_name])
+      catalog.add_resource package, @glance_api_paste_ini
+      dependency = @glance_api_paste_ini.autorequire
+      expect(dependency.size).to eq(1)
+      expect(dependency[0].target).to eq(@glance_api_paste_ini)
+      expect(dependency[0].source).to eq(package)
+    end
+  end
+
+  context 'on Debian platforms' do
+    let :platform_params do
+      { :package_name => 'glance-api',
+        :osfamily     => 'Debian' }
+    end
+
+    it_behaves_like 'glance_api_paste_ini'
+  end
+
+  context 'on RedHat platforms' do
+    let :platform_params do
+      { :package_name => 'openstack-glance',
+        :osfamily     => 'RedHat'}
+    end
+
+    it_behaves_like 'glance_api_paste_ini'
+  end
+
+end

spec/unit/type/glance_registry_paste_ini_spec.rb

@@ -0,0 +1,87 @@
+require 'puppet'
+require 'puppet/type/glance_registry_paste_ini'
+
+describe 'Puppet::Type.type(:glance_registry_paste_ini)' do
+  before :each do
+    Puppet::Type.rmtype(:glance_registry_paste_ini)
+    Facter.fact(:osfamily).stubs(:value).returns(platform_params[:osfamily])
+    @glance_registry_paste_ini = Puppet::Type.type(:glance_registry_paste_ini).new(:name => 'DEFAULT/foo', :value => 'bar')
+  end
+
+  shared_examples_for 'glance_registry_paste_ini' do
+
+    it 'should require a name' do
+      expect {
+        Puppet::Type.type(:glance_registry_paste_ini).new({})
+      }.to raise_error(Puppet::Error, 'Title or name must be provided')
+    end
+
+    it 'should not expect a name with whitespace' do
+      expect {
+        Puppet::Type.type(:glance_registry_paste_ini).new(:name => 'f oo')
+      }.to raise_error(Puppet::Error, /Parameter name failed/)
+    end
+
+    it 'should fail when there is no section' do
+      expect {
+        Puppet::Type.type(:glance_registry_paste_ini).new(:name => 'foo')
+      }.to raise_error(Puppet::Error, /Parameter name failed/)
+    end
+
+    it 'should not require a value when ensure is absent' do
+      Puppet::Type.type(:glance_registry_paste_ini).new(:name => 'DEFAULT/foo', :ensure => :absent)
+    end
+
+    it 'should accept a valid value' do
+      @glance_registry_paste_ini[:value] = 'bar'
+      expect(@glance_registry_paste_ini[:value]).to eq('bar')
+    end
+
+    it 'should not accept a value with whitespace' do
+      @glance_registry_paste_ini[:value] = 'b ar'
+      expect(@glance_registry_paste_ini[:value]).to eq('b ar')
+    end
+
+    it 'should accept valid ensure values' do
+      @glance_registry_paste_ini[:ensure] = :present
+      expect(@glance_registry_paste_ini[:ensure]).to eq(:present)
+      @glance_registry_paste_ini[:ensure] = :absent
+      expect(@glance_registry_paste_ini[:ensure]).to eq(:absent)
+    end
+
+    it 'should not accept invalid ensure values' do
+      expect {
+        @glance_registry_paste_ini[:ensure] = :latest
+      }.to raise_error(Puppet::Error, /Invalid value/)
+    end
+
+    it 'should autorequire the package that install the file' do
+      catalog = Puppet::Resource::Catalog.new
+      package = Puppet::Type.type(:package).new(:name => platform_params[:package_name])
+      catalog.add_resource package, @glance_registry_paste_ini
+      dependency = @glance_registry_paste_ini.autorequire
+      expect(dependency.size).to eq(1)
+      expect(dependency[0].target).to eq(@glance_registry_paste_ini)
+      expect(dependency[0].source).to eq(package)
+    end
+  end
+
+  context 'on Debian platforms' do
+    let :platform_params do
+      { :package_name => 'glance-registry',
+        :osfamily     => 'Debian' }
+    end
+
+    it_behaves_like 'glance_registry_paste_ini'
+  end
+
+  context 'on RedHat platforms' do
+    let :platform_params do
+      { :package_name => 'openstack-glance',
+        :osfamily     => 'RedHat'}
+    end
+
+    it_behaves_like 'glance_registry_paste_ini'
+  end
+
+end