Commit Graph

288 Commits (51c2793738813c0385b08a810e9c54efcda1a739)

Author SHA1 Message Date
iberezovskiy 51c2793738 Use oslo module for messaging (rabbit) configuration
Additonal changes:

  * switch messaging related parameters to $::os_service_default
    as they are used in oslo::messaging_rabbit define
  * update unit tests
  * update docs for notify::rabbitmq class
  * drop deprecated rabbit_durable_queues parameter
  * fix notification parameters according to mitaka config file

Change-Id: Ib20c13f136a299c958d9ac064e8ad93ceb0ebd40
2016-04-13 13:29:23 +03:00
Javier Pena 109cda8b24 Fix image list in glance_image provider changed the way images are listed,
by removing the '--long' parameter. This breaks when called by the
openstacklib provider, because that was the "properties" argument in
adb0b1d012/lib/puppet/provider/openstack.rb (L74)
so the command-line used '' as a last argument, causing the failure.

This will require a stable/mitaka backport.

Change-Id: I69e3cc848fbacbda01f9bd7d8a079c99b15cb5cf
2016-04-08 19:27:00 +00:00
Emilien Macchi 31c15aefd4 acceptance: drop dependency cycles tests
They bring no value in our CI, we already test a full deployment of
Glance and workflow of image upload, we don't need them.
Moreover, they make our life complicated when debbuging CI issues.

Let's drop the tests.

Change-Id: I94fa88d661dc83d4f1803ab3275ff0cfa58b6c5b
2016-04-08 15:24:42 -04:00
Jenkins 5d6e42356e Merge "Switch glance to os_service_default facts" 2016-04-07 14:11:53 +00:00
Mykyta Karpin 037545fb3e Switch glance to os_service_default facts
Change-Id: If860858e2bdfe0387b6a3260b81a97625d05b9fe
2016-04-06 18:56:34 +03:00
Jenkins ecfcaa5264 Merge "Add ability to set properties with glance_image" 2016-04-05 11:51:17 +00:00
Michael Polenchuk d0957fb622 Add ability to set properties with glance_image
This change updates the glance_image provider to support the ability to
specify properties for an image.  This change only adds the support for
setting properties. The conversion and update to using the v2 will
require further rework of this provider.

Change-Id: I22b92c5ccd0f77c837e9abe987cee07c7d90867e
Co-Authored-By: Alex Schultz <>
2016-04-04 14:57:25 -06:00
Jenkins 4923d0441c Merge "Implement ability to pass CA bundle certificate for vCenter server" 2016-04-04 13:18:20 +00:00
Igor Zinovik a1fbd1a42c Implement ability to pass CA bundle certificate for vCenter server
Glance with vsphere backend by default verifies vCenter server TLS/SSL
certificate using system truststore (e.g.
/etc/ssl/certs/ca-certificates.crt). Here is a problem with connection
to vCenter: if we consider case with default installation, then vCenter
starts with self-signed certificate which cannot be verified using linux
shipped CA bundle. Glance starts, but fails to do any useful work,
because it generates SSL errors due to inability to verify vCenter
TLS/SSL certificate.

User can provide its own CA bundle file for Glance to verify connection,
but currently puppet-glance does not support this. This patch aims to
fix this problem, it:
- introduces new optional parameter $vcenter_ca_file which undef by
  default, which means that value will not be written to glance-api.conf
- it switches default value of vmware_api_insecure to True
- provides rspec tests for changed behaviour

Change-Id: Icef5c35ad1128df465da548dd880a0dfeeadb5e1
Related-bug: #1559067
2016-04-04 07:34:25 +00:00
Dan Prince 006c32a38f Add options to set swift auth domains
We need options to be able to set the user and project domain
when using keystone v3 credentials for the swift backend. Without
these options keystone v3 swift will fail.

Change-Id: Id384b0eca750e0946b42cb8ccb60a7f9ed64d21a
2016-04-01 14:16:12 -04:00
Denis Egorenko ea0c4d5b51 Add posibility to configure Glance backend settings for Glare service
This patch adds posibility to configure backend settings for Glare

Since Glare service is experimental feature, it can be usually disabled
for deployment. Hence was added a optional parameter 'glare_enabled' for
each backend manifest. So, if Glare is enabled glance glare config
will (and should) have same backend options as main glance api config.

Change-Id: I112a332f490d2e57eef5fa7d41d465c0eb89da04
Related-bug: #1555697
2016-03-28 16:18:13 +03:00
Jenkins 3941da05fc Merge "Add missed glare_config options for glance::config class" 2016-03-24 21:19:20 +00:00
Denis Egorenko a2fe12405e Add missed glare_config options for glance::config class
Change I3371d1d57486e79ccfae565417f2195d3ae66bc9 is introduced a new
glance service - Glare, but it missed options for glance::config

Also this patch adds tests for glance::config class

Change-Id: Ie07480562b2c0761f5218eb00b3ed3f335bd7cfb
2016-03-24 13:49:06 +03:00
Denis Egorenko e0b34f450d Configure endpoint for Glance Glare
Change I3371d1d57486e79ccfae565417f2195d3ae66bc9 is introduced a new
glance service - Glare and it has own endpoint. This patch adds it.

Change-Id: Ibea50c249e6f0f33dbcfae4bf7cf3569f27c21e5
Related-bug: #1555697
2016-03-23 21:16:18 +03:00
Denis Egorenko da8a3aa022 Add Glance Glare API service
In Mitaka Glance v3 was moved to stand alone service [1] - now
it's called Glance Artifacts Repository (Glare).

This patch adds appropriate service managing, package installation,
configuration and related spec tests.

[1] I5b7bd4cdcc5f2a40fc4a5f74bcc422fd700c4fb0

Change-Id: I3371d1d57486e79ccfae565417f2195d3ae66bc9
Closes-bug: #1555697
2016-03-22 18:50:29 +03:00
Xingchao 5eacf1c039 Update stores option's example value
stores and default_store option's example value has changed.
See more info in [1].


Change-Id: I913be3415c02adbaa3b1aafe120366a097ede09d
2016-03-18 11:23:20 +08:00
Jenkins fbf285e95d Merge "api: allow ssl communications with registry" 2016-03-10 14:35:20 +00:00
Emilien Macchi 7bf43b2b13 api: allow ssl communications with registry
Add missing options to allow Glance API to connect to Glance Registry
when SSL is enabled on both services.
Also switching SSL options to os_service_default to avoid useless
conditions in manifests.

Change-Id: Ia40228fc165ef8ce1213fed7f5eec4de1c12c013
2016-03-09 13:23:07 -05:00
Mykyta Karpin 7d1c73ba0a spec: Add Unit Tests for glance paste_ini types/providers
Change-Id: Ia6688b80f983c76db5b076eafc842bfe2be4481b
Partial-bug: #1440401
2016-03-09 14:47:48 +03:00
Jenkins bf7765f66d Merge "Remove POSIX users, groups, and file modes." 2016-03-09 00:03:32 +00:00
Drew Fisher 637f986252 Remove POSIX users, groups, and file modes.
This patch removes File resources which should be delivered by packaging
tools.  These resources (files, directories, modes, users, and group
attributes) could be in conflict with different OS packaging systems
which isn't a desired result.

Co-Authored-By: Ivan Berezovskiy <>

Closes-Bug: #1458915

Change-Id: I02fe8cc99dcd56e16ac66136a0da244a1eeb630b
2016-03-08 15:48:10 +02:00
Nate Potter 22231b2d66 Implement multiple store configuration
This patch moves the default_store config option to the glance::api
class, and makes it possible to configure more than one store while
supplying a value for the default store to be used. If only one store
is given for glance_store/stores, the default store is automatically
set to be the same value. If multiple stores are given and no default
store is explicitly set, the config will fail and ask the user to
provide a default store.

Change-Id: I28a79ae36e673a3537ea16910d338666b65c80f7
Closes-bug: #1481460
Co-Authored-By: Alex Schultz <>
2016-03-05 00:32:39 +00:00
Alex Schultz cda71192de Switch glance to rspec-puppet-facts
This change updates the glance tests to use rspec-puppet-facts to test
multiple operating systems.

Change-Id: I75fd8970ba8335cb4ffa09a7d600415056e9f889
2016-02-29 16:33:46 -07:00
Emilien Macchi 624f522e71 Supports IPv6 in registry_host
This patch add support for IPv6 address in registry_host.
It adds brackets if an IPv6 is detected.

Change-Id: Ic1d75984fac7bce3d0239df54a877ae2b713c442
2016-02-29 12:57:49 -05:00
Denis Egorenko b3160011aa Use http protocol by default in auth_address for Swift backend
This commit explicitly sets default protocol to http in
swift_store_auth_address variable for Swift backend, because without
any specified protocol it will use https by default. That's not
consistent with other default values for protocols in auth addresses.

Change-Id: I232536d179db92d82f1c7459a0f13e5ca5576f42
2016-02-26 16:10:45 +03:00
Denis Egorenko c8b7d3319b Use glance-swift conf for swift backend
For working with Swift backend, Glance needs authentication parameters,
which are supplied to Swift when making calls to its storage system.
Glance will use information from the file specified under parameter
swift_store_config_file. When this parameter is set to the same file
(glance-api.conf), we have lot of non-critical errors in glance-api
log, because of 'Invalid format of swift store config'.

The same problem, when we have RadosGW.

Change-Id: I18ee8f68f7ce793d2580685e79ed636556c57ddd
Related-bug: #1540890
2016-02-02 17:34:33 +03:00
gcmalloc 7e2e1162d0 Add support for min ram and min disk
Add min_ram and min_disk properties to the glance_image resource.

Change-Id: I27202559bc73283a318575669c957238f5aee988
2016-01-25 17:54:41 -08:00
Emilien Macchi 28bcf83e14 drop mock dependency
mock is not used anywhere in the module, let's drop it.
This patch will help to hit this bug:

Change-Id: I427b83d65ac850329e227310a2e3888d5c8c5cd1
2016-01-22 09:39:26 -05:00
Emilien Macchi 67bd15682e Use puppet-openstack_spec_helper for Rakefile & spec_helper_acceptance
Use common code in puppet-openstack_spec_helper in Rakefile and

Change-Id: Ia9279876369e1ae1d0062eae4b103fca5256c452
2016-01-18 09:11:17 -05:00
Jenkins b2aa99e0b8 Merge "Use openstack spec helper for spec defaults" 2016-01-16 18:09:24 +00:00
Jenkins 1f8cacb736 Merge "Add memcached_servers parameter" 2016-01-14 19:55:04 +00:00
Denis Egorenko 258b1905da Use openstack spec helper for spec defaults
* Add puppet-openstack_spec_helper to Gemfile
* Use puppet-openstack_spec_helper/defaults in spec_helper
* Delete spec/defaults.rb, useless now

Change-Id: Ic30d5f0a4e9e4674b378bb74c140dc7b5d81f7b4
2016-01-14 21:04:15 +03:00
Xingchao Yu f444097a71 Add memcached_servers parameter
This patch is aim to add memcached_servers parameter in glance-api
and glance-registry service.

Change-Id: I4f671ebcda63007fa13f86655b9988648592b68b
2016-01-14 02:45:19 +08:00
Jenkins e58c73f9c6 Merge "Update to pull in rspec-puppet-facts" 2016-01-13 13:13:21 +00:00
Jenkins a3bccf6363 Merge "Create glance::cache::logging class" 2016-01-12 15:11:24 +00:00
Jenkins 429c256ebc Merge "Fix Swift store configuration" 2016-01-11 13:52:46 +00:00
Yanis Guenane 72fbeed3dc Create glance::cache::logging class
This review creates the glance::cache::logging class to be in feature
parity with glance::api and glance::registry.

Change-Id: Ia3f27e991b1e525ee3604502d6afc6dc7d45247c
2016-01-11 16:10:16 +03:00
Ben Nemec c324788ff6 Fix Swift store configuration
The swift_store_config_file option is being set in the DEFAULT
group instead of the glance_store group where it is actually
defined in Glance.  This causes configuration of the Swift store
backend to fail because the configuration is not found by the
check here:

Moving the option to glance_store makes the Swift backend work again.

Change-Id: I3af198e5015df1d626c4a5aaccb3b4e5781f56b8
Closes-Bug: 1532352
2016-01-09 00:03:19 +00:00
Xingchao Yu 81333fce40 Add rabbit_ha_queues option
There are two ways for setting up RabbitMQ HA:

 1. Configure $rabbit_hosts to multi rabbit hosts.
 2. Setting up a loadbalancer in front of RabbitMQ cluster,
    provide a unique address in $rabbit_host

In current, rabbit_ha_queues option is controled by rabbit_hosts
if conditional statement. When users try the second method:
changing rabbit_ha_queues to true. If they don't set rabbit_hosts,
then current logic will not work.

This patch is aim to add an rabbit_ha_queues option, set it to undef
by default for forward compatbility.

Change-Id: I9f61c113b41cb00f7f95e80e2cabe1641aed74e7
Close-Bug: #1485287
2016-01-07 08:57:52 +00:00
Alex Schultz c9f7cbc8b5 Update to pull in rspec-puppet-facts
Change-Id: Ic591dff6d2927a027f29970e6b18020dc589ce7f
2016-01-06 21:28:07 -07:00
Jenkins aa3be49105 Merge "Default service_name to 'Image Service'" 2016-01-05 17:58:06 +00:00
Jenkins aea8027cbd Merge "Use identity_uri and auth_uri by default" 2016-01-05 17:51:56 +00:00
Emilien Macchi 17101434e1 Set os_region_name to $::os_service_default and drop warning
This commit [1] introduced a weird warning that send a warning by

This patch:
* sets os_region_name to the default value in OpenStack using
* drops the warning

[1] Id7a6894e5bb12fc7697dfe23e5f9d4a44a719086

Change-Id: Id4e94e18bad19c605bb82d3fb16b867493dab4c3
2016-01-03 10:47:47 -05:00
Emilien Macchi 148253cd27 Use identity_uri and auth_uri by default
Change-Id: I8ef94a18fd24f9572830994bcd005691d2314d66
Closes-Bug: #1528963
2016-01-02 08:57:56 -05:00
Emilien Macchi 80faf9a017 Default service_name to 'Image Service'
In Liberty, we sent a warning if service_name was not set (and auth_name
was configured as the service name), with the goal to define the correct
default value during Mitaka.

This patch set the service_name parameter to 'Image Service' by default
to match with Keystone's default catalog.

Note: if you already run OpenStack, when you'll run Puppet after this
change, the old service will still be present and you'll have to drop it
manually. Though the Glance endpoint will be updated with the new

Change-Id: I740a9ad32361e6a78277ea0667fba7f631eb64af
Closes-bug: #1506061
2015-12-24 16:52:10 +01:00
Emilien Macchi 5917ed6fb8 Set auth_region to $::os_service_default and drop warning
This commit [1] introduced a weird warning that send a warning by

This patch:
* sets auth_region to the default value in OpenStack using
* drops the warning

[1] Id7a6894e5bb12fc7697dfe23e5f9d4a44a719086

Change-Id: Ia5fcbb6333c3466232ac16a552f90f950313230f
2015-12-23 23:06:15 +01:00
Jenkins 8e506f0167 Merge "Add more settings to glance-api" 2015-12-23 10:10:03 +00:00
Gael Chamoulaud 0e82931439 Fix unit tests failing against puppet 4.3.x
Change-Id: I12d569cd4d916b4b19c0287f70bc5b4e4f67b411
Signed-off-by: Gael Chamoulaud <>
2015-12-22 20:20:03 +00:00
Emilien Macchi 866af363f3 Make Keystone_endpoint match service by name/type
Since a chance in puppet-keystone (1], we now match an endpoint with a
service name/type.
This patch reflects this change for 'image' service endpoint.

Closes-Bug: #1528308

Change-Id: Idff0ff4052ee9db4395a0b556f4c01c5538450dd
2015-12-22 18:06:57 +01:00
Jake Yip 8b4b305bc8 Add more settings to glance-api
Add settings
 * location_strategy
 * show_multiple_locations

Change-Id: I64b1d5a29faeed98316d4f44c9f24bf2f82a3d35
2015-12-22 21:05:16 +11:00