This change adds possibility to use the os_service_default
fact for configuration options that default to '<SERVICE DEFAULT>'.
this change is done by analogy with cinder
commit 667e6c0850672dbbf99381eb92468f95e5591913
Change-Id: Ie5c8909bcc1c9a6a7a9ab1b59eec4637751ffd74
Do not make ::glance::backend::file inherits from ::glance::api because
::glance::api has parameters.
The class was broken until now.
Also, we need to include glance::backend::file to have
'filesystem_store_datadir' parameter in Glance config, since we're using
file backend.
If you don't provide this parameter, Glance fails to start:
glance_store._drivers.filesystem [-] Specify at least
'filesystem_store_datadir' or 'filesystem_store_datadirs' option
Change-Id: Iba6791199f7a2c7fef24b1e8752ed0b564b8512f
This patch aim to update our specs test in order to work with the rspec-puppet release
2.0.0, in the mean time, we update rspec syntax in order to be prepared
for rspec 3.x move.
In details:
* Use shared_examples "a Puppet::Error" for puppet::error tests
* Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
* Fix spec tests for rspec-puppet 2.0.0
* Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
* Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper)
Change-Id: Ibd0333dc3c0959e846edfbad51fb48e8dfb8fbe9
Card: https://trello.com/c/eHXc1Ryd/4-investigate-the-necessary-change-to-be-rspec-puppet-2-0-0-compliant
glance::backend::file was not properly configuring
filesystem_store_datadir in /etc/glance/glance-cache.conf
when using file backend.
Change-Id: Ie8d3259de429089f2f00fbafd2e5cbf90c069263
using RI's version of the concat module.
It introduces a custom fact concat_basedir that can determine
where the vardir is for a particular agent.
This commits adds that fact to unit tests that are validating
the resuling fragment files.
I had previously checked in some broken tests that
resulted from the updating the concat fragments names
to ensure uniqueness between services (eg, choosing
fragment names like HEADER were causing
duplicate resource errors, these have been prefixed
with the service name glance-api to ensure uniqueness)
This commit updates the tests so that they work for
this previous commit (oops!)
This commit resolves failing tests from
glance::api and glance::registry related to recent
refactors.
It also adds tests for all of the new api fragment
classes/defines.
