b011f42591
This commit moves conditionals based on values obtained from Facter inside code blocks that are only executed on agents and replaces the use of Facter['osfamily'].value with Facter.value:(:osfamily). Without this change we are returning values based off the master's facts, so if a Debian agent checks into a RedHat master then the type is currently making a decision based off of RedHat and not the actual OS of the agent running the catalog. Code ran outside blocks is evaluated on masters and inside a block is evaluated by the agent when the catalog is executed. We do not notice this because all our testing uses "puppet apply" and autorequire only matters when they find a matching resource name in the catalog. The latter results in no error because the relationship is simply ignored on the Debian agent if a package resource with the RedHat name is not found. This issue was found by running facter 3, the C++11 re-implementation under the jruby and clojure implemented puppetserver. The clojure jni shim written so that facter can be ran inside of puppetserver does not implement the [] method for the Facter module but the ruby shim does. So I noticed that the code had an issue when Facter['osfamily'].value was executed on the master, which returned a not method error. Once again, something we didn't notice becuase we do not test against a master. I decided to migrate to Facter.value(:osfamily) to simply keep to an API that is consistent across both puppet and puppetserver but fixing where the code runs does actually solve the not method found error. Change-Id: I773f20e0bc1e917f6ec5fa8830f5bbfa60b6cd8a |
||
---|---|---|
ext | ||
lib/puppet | ||
manifests | ||
spec | ||
tests | ||
.gitignore | ||
.gitreview | ||
CHANGELOG.md | ||
Gemfile | ||
LICENSE | ||
metadata.json | ||
Rakefile | ||
README.md |
glance
6.1.0 - 2015.1 - Kilo
Table of Contents
- Overview - What is the glance module?
- Module Description - What does the module do?
- Setup - The basics of getting started with glance
- Implementation - An under-the-hood peek at what the module is doing
- Limitations - OS compatibility, etc.
- Development - Guide for contributing to the module
- Contributors - Those with commits
Overview
The glance module is a part of OpenStack, an effort by the OpenStack infrastructure team to provide continuous integration testing and code review for OpenStack and OpenStack community projects as part of the core software. The module its self is used to flexibly configure and manage the image service for OpenStack.
Module Description
The glance module is a thorough attempt to make Puppet capable of managing the entirety of glance. This includes manifests to provision such things as keystone endpoints, RPC configurations specific to glance, and database connections. Types are shipped as part of the glance module to assist in manipulation of configuration files.
This module is tested in combination with other modules needed to build and leverage an entire OpenStack software stack. These modules can be found, all pulled together in the openstack module.
Setup
What the glance module affects
- Glance, the image service for OpenStack.
Installing glance
puppet module install openstack/glance
Beginning with glance
To utilize the glance module's functionality you will need to declare multiple resources. The following is a modified excerpt from the openstack module. This is not an exhaustive list of all the components needed, we recommend you consult and understand the openstack module and the core openstack documentation.
Define a glance node
class { 'glance::api':
verbose => true,
keystone_tenant => 'services',
keystone_user => 'glance',
keystone_password => '12345',
database_connection => 'mysql://glance:12345@127.0.0.1/glance',
}
class { 'glance::registry':
verbose => true,
keystone_tenant => 'services',
keystone_user => 'glance',
keystone_password => '12345',
database_connection => 'mysql://glance:12345@127.0.0.1/glance',
}
class { 'glance::backend::file': }
Setup postgres node glance
class { 'glance::db::postgresql':
password => '12345',
}
Setup mysql node for glance
class { 'glance::db::mysql':
password => '12345',
allowed_hosts => '%',
}
Setup up keystone endpoints for glance on keystone node
class { 'glance::keystone::auth':
password => '12345'
email => 'glance@example.com',
public_address => '172.17.0.3',
admin_address => '172.17.0.3',
internal_address => '172.17.1.3',
region => 'example-west-1',
}
Setup up notifications for multiple RabbitMQ nodes
class { 'glance::notify::rabbitmq':
rabbit_password => 'pass',
rabbit_userid => 'guest',
rabbit_hosts => [
'localhost:5672', 'remotehost:5672'
],
rabbit_use_ssl => false,
}
Types
glance_api_config
The glance_api_config
provider is a children of the ini_setting provider. It allows one to write an entry in the /etc/glance/glance-api.conf
file.
glance_api_config { 'DEFAULT/verbose' :
value => true,
}
This will write verbose=true
in the [DEFAULT]
section.
name
Section/setting name to manage from glance-api.conf
value
The value of the setting to be defined.
secret
Whether to hide the value from Puppet logs. Defaults to false
.
ensure_absent_val
If value is equal to ensure_absent_val then the resource will behave as if ensure => absent
was specified. Defaults to <SERVICE DEFAULT>
glance_registry_config
The glance_registry_config
provider is a children of the ini_setting provider. It allows one to write an entry in the /etc/glance/glance-registry.conf
file.
glance_registry_config { 'DEFAULT/verbose' :
value => true,
}
This will write verbose=true
in the [DEFAULT]
section.
name
Section/setting name to manage from glance-registry.conf
value
The value of the setting to be defined.
secret
Whether to hide the value from Puppet logs. Defaults to false
.
ensure_absent_val
If value is equal to ensure_absent_val then the resource will behave as if ensure => absent
was specified. Defaults to <SERVICE DEFAULT>
glance_cache_config
The glance_cache_config
provider is a children of the ini_setting provider. It allows one to write an entry in the /etc/glance/glance-cache.conf
file.
glance_cache_config { 'DEFAULT/verbose' :
value => true,
}
This will write verbose=true
in the [DEFAULT]
section.
name
Section/setting name to manage from glance-cache.conf
value
The value of the setting to be defined.
secret
Whether to hide the value from Puppet logs. Defaults to false
.
ensure_absent_val
If value is equal to ensure_absent_val then the resource will behave as if ensure => absent
was specified. Defaults to <SERVICE DEFAULT>
Implementation
glance
glance is a combination of Puppet manifest and ruby code to deliver configuration and extra functionality through types and providers.
Limitations
- Only supports configuring the file, swift and rbd storage backends.
Beaker-Rspec
This module has beaker-rspec tests
To run the tests on the default vagrant node:
To run:
bundle install
bundle exec rspec spec/acceptance
For more information on writing and running beaker-rspec tests visit the documentation:
Development
Developer documentation for the entire puppet-openstack project.