openstack/puppet-glare
Code Issues Proposed changes

Do not validate database_connection format

Browse Source 
Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: Iedacb092d2c4427f77e82c9b3e0191a04e0f2278
This commit is contained in:
Takashi Kajinami 2020-08-31 00:05:20 +09:00
parent 38989934bf
commit a26d59dd66
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/db.pp
View File

@ -63,9 +63,6 @@ class glare::db (
warning('The database_min_pool_size parameter is deprecated, and will be removed in a future release.') warning('The database_min_pool_size parameter is deprecated, and will be removed in a future release.')
} }
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection,
['^(sqlite|mysql(\+pymysql)?|postgresql):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { 'glare_config': oslo::db { 'glare_config':
connection => $database_connection, connection => $database_connection,
connection_recycle_time => $database_connection_recycle_time, connection_recycle_time => $database_connection_recycle_time,