openstack
/
puppet-gnocchi
Code Issues Proposed changes

Configure s3_secret_access_key as secret 

Parameter s3_secret_access_key should be configured as a secret.

Change-Id: I65ed470a1f585ed4704057a71511451c8db44f8c
Closes-Bug: #1847941
Depends-On: https://review.opendev.org/688319
(cherry picked from commit 05ee0bb433)
This commit is contained in:
ZhongShengping 2019-10-14 08:52:25 +08:00 committed by zhongshengping
parent c4405891b7
commit 4bfed23cfb
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/storage/s3.pp
View File

@ -40,7 +40,7 @@ class gnocchi::storage::s3(
'storage/s3_endpoint_url': value => $s3_endpoint_url;
'storage/s3_region_name': value => $s3_region_name;
'storage/s3_access_key_id': value => $s3_access_key_id;
'storage/s3_secret_access_key': value => $s3_secret_access_key;
'storage/s3_secret_access_key': value => $s3_secret_access_key, secret => true;
'storage/s3_bucket_prefix': value => $s3_bucket_prefix;
}

2
spec/classes/gnocchi_storage_s3_spec.rb
View File

@ -22,7 +22,7 @@ describe 'gnocchi::storage::s3' do
is_expected.to contain_gnocchi_config('storage/s3_endpoint_url').with_value('https://s3-eu-west-1.amazonaws.com')
is_expected.to contain_gnocchi_config('storage/s3_region_name').with_value('eu-west-1')
is_expected.to contain_gnocchi_config('storage/s3_access_key_id').with_value('xyz')
is_expected.to contain_gnocchi_config('storage/s3_secret_access_key').with_value('secret-xyz')
is_expected.to contain_gnocchi_config('storage/s3_secret_access_key').with_value('secret-xyz').with_secret(true)
end
end
end