From 4fab96113b234ca934b5188a5f9d47a2dee34c28 Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Tue, 23 Jul 2024 19:16:44 +0900 Subject: [PATCH] Add support for [healthcheck] enable_by_file_paths Depends-on: https://review.opendev.org/923648 Change-Id: I6f01cc22ee62e3cf89e33df4dbb2000ed51536e9 --- manifests/healthcheck.pp | 7 +++++++ .../notes/hc-enable_by_file_paths-40231ad5bbc4ae0f.yaml | 5 +++++ spec/classes/gnocchi_healthcheck_spec.rb | 3 +++ 3 files changed, 15 insertions(+) create mode 100644 releasenotes/notes/hc-enable_by_file_paths-40231ad5bbc4ae0f.yaml diff --git a/manifests/healthcheck.pp b/manifests/healthcheck.pp index 4415d4cc..1ea78be0 100644 --- a/manifests/healthcheck.pp +++ b/manifests/healthcheck.pp @@ -32,6 +32,11 @@ # is running on a port. Expects a "port:path" list of strings. # Defaults to $facts['os_service_default'] # +# [*enable_by_file_paths*] +# (Optional) Check the presence of files. Used by EnableByFilesHealthcheck +# plugin. +# Defaults to $facts['os_service_default'] +# class gnocchi::healthcheck ( $detailed = $facts['os_service_default'], $backends = $facts['os_service_default'], @@ -39,6 +44,7 @@ class gnocchi::healthcheck ( $ignore_proxied_requests = $facts['os_service_default'], $disable_by_file_path = $facts['os_service_default'], $disable_by_file_paths = $facts['os_service_default'], + $enable_by_file_paths = $facts['os_service_default'], ) { include gnocchi::deps @@ -50,5 +56,6 @@ class gnocchi::healthcheck ( ignore_proxied_requests => $ignore_proxied_requests, disable_by_file_path => $disable_by_file_path, disable_by_file_paths => $disable_by_file_paths, + enable_by_file_paths => $enable_by_file_paths, } } diff --git a/releasenotes/notes/hc-enable_by_file_paths-40231ad5bbc4ae0f.yaml b/releasenotes/notes/hc-enable_by_file_paths-40231ad5bbc4ae0f.yaml new file mode 100644 index 00000000..55ef8219 --- /dev/null +++ b/releasenotes/notes/hc-enable_by_file_paths-40231ad5bbc4ae0f.yaml @@ -0,0 +1,5 @@ +--- +features: + - | + The new ``gnocchi::healthcheck::enable_by_file_paths`` parameter has been + added. diff --git a/spec/classes/gnocchi_healthcheck_spec.rb b/spec/classes/gnocchi_healthcheck_spec.rb index 030d1c3b..254e5fd6 100644 --- a/spec/classes/gnocchi_healthcheck_spec.rb +++ b/spec/classes/gnocchi_healthcheck_spec.rb @@ -17,6 +17,7 @@ describe 'gnocchi::healthcheck' do :ignore_proxied_requests => '', :disable_by_file_path => '', :disable_by_file_paths => '', + :enable_by_file_paths => '', ) end end @@ -30,6 +31,7 @@ describe 'gnocchi::healthcheck' do :ignore_proxied_requests => false, :disable_by_file_path => '/etc/gnocchi/healthcheck/disabled', :disable_by_file_paths => ['8004:/etc/gnocchi/healthcheck/disabled'], + :enable_by_file_paths => ['/etc/gnocchi/healthcheck/enabled'], } end @@ -41,6 +43,7 @@ describe 'gnocchi::healthcheck' do :ignore_proxied_requests => false, :disable_by_file_path => '/etc/gnocchi/healthcheck/disabled', :disable_by_file_paths => ['8004:/etc/gnocchi/healthcheck/disabled'], + :enable_by_file_paths => ['/etc/gnocchi/healthcheck/enabled'], ) end end