openstack
/
puppet-gnocchi
Code Issues Proposed changes

Add tag to package and service resources 

In order to be able to take an action after all the packages of the
module have been installed/updated or all the services have been
started/restarted, we set a 'gnocchi-package' and 'gnocchi-service'
tag for each package and service of this module.

At the moment, there is a generic openstack tag that is not specific
enough if one wants to take action upon a single module change.

Use case :

If an action needs to be taken after all the packages have been
installed or updated : Package <| tag == 'gnocchi-package' |> -> X

Change-Id: I90902e01bd095e1b0f6a2944ceedfc53de6f7b01
This commit is contained in:
Yanis Guenane 2015-07-22 16:41:09 +02:00
parent dc2a8521b4
commit b3e503c3e0
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/generic_service.pp
View File

@ -68,6 +68,7 @@ define gnocchi::generic_service(
ensure => $ensure_package,
name => $package_name,
notify => Service[$gnocchi_title],
tag => ['openstack', 'gnocchi-package'],
}
}
}
@ -86,6 +87,7 @@ define gnocchi::generic_service(
name => $service_name,
enable => $enabled,
hasstatus => true,
tag => 'gnocchi-service',
}
}
}

12
spec/shared_examples.rb
View File

@ -11,13 +11,15 @@ shared_examples 'generic Gnocchi service' do |service|
is_expected.to contain_package(service[:name]).with({
:name => service[:package_name],
:ensure => 'present',
:notify => "Service[#{service[:name]}]"
:notify => "Service[#{service[:name]}]",
:tag => ['openstack', 'gnocchi-package'],
})
is_expected.to contain_service(service[:name]).with({
:name => service[:service_name],
:ensure => 'stopped',
:hasstatus => true,
:enable => false
:enable => false,
:tag => 'gnocchi-service',
})
end
end
@ -32,13 +34,15 @@ shared_examples 'generic Gnocchi service' do |service|
is_expected.to contain_package(service[:name]).with({
:name => service[:package_name],
:ensure => '2014.1-1',
:notify => "Service[#{service[:name]}]"
:notify => "Service[#{service[:name]}]",
:tag => ['openstack', 'gnocchi-package'],
})
is_expected.to contain_service(service[:name]).with({
:name => service[:service_name],
:ensure => 'running',
:hasstatus => true,
:enable => true
:enable => true,
:tag => 'gnocchi-service',
})
end
end