From b3e503c3e09b24c1540ac13bba8c07181f10563a Mon Sep 17 00:00:00 2001 From: Yanis Guenane Date: Wed, 22 Jul 2015 16:41:09 +0200 Subject: [PATCH] Add tag to package and service resources In order to be able to take an action after all the packages of the module have been installed/updated or all the services have been started/restarted, we set a 'gnocchi-package' and 'gnocchi-service' tag for each package and service of this module. At the moment, there is a generic openstack tag that is not specific enough if one wants to take action upon a single module change. Use case : If an action needs to be taken after all the packages have been installed or updated : Package <| tag == 'gnocchi-package' |> -> X Change-Id: I90902e01bd095e1b0f6a2944ceedfc53de6f7b01 --- manifests/generic_service.pp | 2 ++ spec/shared_examples.rb | 12 ++++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/manifests/generic_service.pp b/manifests/generic_service.pp index 9530cc15..9e0e898a 100644 --- a/manifests/generic_service.pp +++ b/manifests/generic_service.pp @@ -68,6 +68,7 @@ define gnocchi::generic_service( ensure => $ensure_package, name => $package_name, notify => Service[$gnocchi_title], + tag => ['openstack', 'gnocchi-package'], } } } @@ -86,6 +87,7 @@ define gnocchi::generic_service( name => $service_name, enable => $enabled, hasstatus => true, + tag => 'gnocchi-service', } } } diff --git a/spec/shared_examples.rb b/spec/shared_examples.rb index 4bc52a92..a888e462 100644 --- a/spec/shared_examples.rb +++ b/spec/shared_examples.rb @@ -11,13 +11,15 @@ shared_examples 'generic Gnocchi service' do |service| is_expected.to contain_package(service[:name]).with({ :name => service[:package_name], :ensure => 'present', - :notify => "Service[#{service[:name]}]" + :notify => "Service[#{service[:name]}]", + :tag => ['openstack', 'gnocchi-package'], }) is_expected.to contain_service(service[:name]).with({ :name => service[:service_name], :ensure => 'stopped', :hasstatus => true, - :enable => false + :enable => false, + :tag => 'gnocchi-service', }) end end @@ -32,13 +34,15 @@ shared_examples 'generic Gnocchi service' do |service| is_expected.to contain_package(service[:name]).with({ :name => service[:package_name], :ensure => '2014.1-1', - :notify => "Service[#{service[:name]}]" + :notify => "Service[#{service[:name]}]", + :tag => ['openstack', 'gnocchi-package'], }) is_expected.to contain_service(service[:name]).with({ :name => service[:service_name], :ensure => 'running', :hasstatus => true, - :enable => true + :enable => true, + :tag => 'gnocchi-service', }) end end