openstack
/
puppet-gnocchi
Code Issues Proposed changes

gnocchi::db: Do not test behavior of lower libraries 

Current unit tests of gnocchi::db tests behavior of puppetlabs-mysql
and puppetlabs-postgresql but this is not necessary and makes our
maintenance difficult because we need to update our tests according
to changes in lower libraries.

This makes these unit tests assert only interfaces and stop testing
behavior of these classes imported from libraries.

Change-Id: I94744b06d37a3a6b28bf8ea09c1096e454676b12
This commit is contained in:
Takashi Kajinami 2022-02-02 22:22:27 +09:00
parent b0656ac23b
commit ea401f3f6f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
spec/classes/gnocchi_db_spec.rb
View File

@ -27,7 +27,7 @@ describe 'gnocchi::db' do
{ :database_connection => 'postgresql://gnocchi:gnocchi@localhost/gnocchi', }
end
it { should contain_package('python-psycopg2').with_ensure('present') }
it { should contain_class('postgresql::lib::python') }
end
context 'with MySQL-python library as backend package' do
@ -37,7 +37,8 @@ describe 'gnocchi::db' do
}
end
it { should contain_package('python-mysqldb').with_ensure('present') }
it { should contain_class('mysql::bindings') }
it { should contain_class('mysql::bindings::python') }
end
context 'with incorrect database_connection string' do