openstack/puppet-horizon
Code Issues Proposed changes

Drop default_dashboard

Browse Source 
default_dashboard was deprecated a long ago in Horizon[1] and
Having that parameter in local_settings triggers the following warning
message.

```
WARNING:root:"dashboards" and "default_dashboard" in (local_)settings
is DEPRECATED now and may be unsupported in some future release.
The preferred way to specify the order of dashboards and the default
dashboard is the pluggable dashboard mechanism (in ...).
```

This change removes that parameter hard-coded in the template file to
get rid of the warning message. Currently the project dashboard is
shown first in Horizon by default so removing the parameter does not
cause any change in behavior.

This also removes these deprecated parameters from the template file
used in unit tests.

[1] 75bc2e6aa86d31f60288021694699302b3873af3

Closes-Bug: #1983390
Change-Id: I8cd5346a553db9ba9f6bdf8ffdd9e7d89d16c4be
This commit is contained in:
Takashi Kajinami 2022-08-04 00:52:03 +09:00
parent aac496aa1b
commit 57905ff386
3 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spec/classes/horizon_init_spec.rb
View File

@ -472,8 +472,6 @@ describe 'horizon' do
'# Custom local_settings.py',
'DEBUG = True',
"HORIZON_CONFIG = {",
" 'dashboards': ('project', 'admin', 'settings',),",
" 'default_dashboard': 'project',",
" 'user_home': 'openstack_dashboard.views.get_user_home',",
" 'ajax_queue_limit': 10,",
" 'auto_fade_alerts': {",
@ -656,8 +654,6 @@ describe 'horizon' do
verify_concat_fragment_contents(catalogue, 'local_settings.py', [
'# Custom local_settings.py',
"HORIZON_CONFIG = {",
" 'dashboards': ('project', 'admin', 'settings',),",
" 'default_dashboard': 'project',",
" 'user_home': 'openstack_dashboard.views.get_user_home',",
" 'ajax_queue_limit': 10,",
" 'auto_fade_alerts': {",
@ -688,8 +684,6 @@ describe 'horizon' do
verify_concat_fragment_contents(catalogue, 'local_settings.py', [
'# Custom local_settings.py',
"HORIZON_CONFIG = {",
" 'dashboards': ('project', 'admin', 'settings',),",
" 'default_dashboard': 'project',",
" 'user_home': 'openstack_dashboard.views.get_user_home',",
" 'ajax_queue_limit': 10,",
" 'auto_fade_alerts': {",

2
spec/fixtures/override_local_settings.py.erb vendored
View File

@ -2,8 +2,6 @@
DEBUG = <%= @django_debug %>
HORIZON_CONFIG = {
'dashboards': ('project', 'admin', 'settings',),
'default_dashboard': 'project',
'user_home': 'openstack_dashboard.views.get_user_home',
'ajax_queue_limit': 10,
'auto_fade_alerts': {

1
templates/local_settings.py.erb
View File

@ -129,7 +129,6 @@ OPENSTACK_KEYSTONE_DEFAULT_DOMAIN = '<%= @keystone_default_domain %>'
# Default OpenStack Dashboard configuration.
HORIZON_CONFIG = {
'default_dashboard': 'project',
'user_home': 'openstack_dashboard.views.get_user_home',
'ajax_queue_limit': 10,
'auto_fade_alerts': {