openstack
/
puppet-horizon
Code Issues Proposed changes

Reflect openstacklib options for apache::vhost resources 

It was discovered that Directory Index was enabled by default, leading
to potential leak of data.

A patch was done in puppet-openstacklib[1], but horizon doesn't use this
common lib, meaning it wasn't properly fixed.

[1] change id Icba53f4e32237556608f4cb6dcd9da1a71705c19

Related-Bug: #1854442
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1729423

Change-Id: Ife921f8409f58b70c5da4c344e330eec56669e20
(cherry picked from commit 7ec0c090eb)
This commit is contained in:
Cédric Jeanneret 2020-02-28 08:08:26 +01:00 committed by Alex Schultz
parent a0f8f78026
commit bacf1cb9e5
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/wsgi/apache.pp
View File

@ -268,6 +268,7 @@ class horizon::wsgi::apache (
ensure_resource('apache::vhost', $vhost_conf_name, merge ($default_vhost_conf, $extra_params, {
redirectmatch_regexp => $redirectmatch_regexp_real,
redirectmatch_dest => $redirectmatch_url_real,
options => ['-Indexes', '+FollowSymLinks','+MultiViews'],
}))
ensure_resource('apache::vhost', $vhost_ssl_conf_name, merge ($default_vhost_conf, $extra_params, {
access_log_file => 'horizon_ssl_access.log',
@ -280,6 +281,7 @@ class horizon::wsgi::apache (
wsgi_process_group => 'horizon-ssl',
redirectmatch_regexp => $root_url_real ? { '' => undef, '/' => undef, default => '^/$' },
redirectmatch_dest => $root_url_real ? { '' => undef, '/' => undef, default => $root_url_real },
options => ['-Indexes', '+FollowSymLinks','+MultiViews'],
}))
}