Commit Graph

11 Commits

Author SHA1 Message Date
Alex Schultz
7f273f3168 Move rspec-puppet-facts to spec helper
This change updates the module to use the rspec-puppet-facts as defined
in the puppet-openstack_spec_helper.

Change-Id: I9c7841f663d08057be641a814bf7afe4123bc0ac
2016-09-30 13:20:38 -06:00
Marcos Fermin Lobo
7385841442 OPENSTACK_KEYSTONE_BACKEND should be configurable
In local_settings.py.erb, OPENSTACK_KEYSTONE_BACKEND is hardcoded.

We needed a new parameter in the module in order to change this to be
configurable.

Change-Id: I3f0859cd0e73012f444191797afc076beb68d7e9
Closes-Bug: #1575227
2016-07-18 20:32:45 +03:00
Alex Schultz
72dcec4e9b Switch horizon to use rspec-puppet-facts
This change updates puppet-horizon to use rspec-puppet-facts for all
rspec tests.

Change-Id: I86e4e32037e7c96b47c12077cd0d2fc30c62c5f9
2016-07-07 15:11:36 -06:00
Emilien Macchi
113e335bf6 drop mock dependency
mock is not used anywhere in the module, let's drop it.
This patch will help to hit this bug:
https://launchpad.net/bugs/1492636

Change-Id: Ie2495846e8a0c2115de5689d3ed3b6751fc781e4
2016-01-22 09:47:02 -05:00
Alex Schultz
3c9b622396 Add rspec-puppet-facts to the spec_helper
This change adds the rspec-puppet-facts gem to the spec helper so that
we can centralize the management of the base operating systems that we
support. rspec-puppet-facts allows us to simplify our unit tests and
provides a more complete list of Operating Systems and their associated
facts for the unit tests.  With this change we can now loop over and
test CentOS, Debian, Fedora, RedHat, and Ubuntu by simply providing a
list of supported os to rspec-puppet-facts.

Additionally this change includes a central object for managing our
supported os list for rspec-puppet-facts and providing our default facts
like os_service_default. This central object should replace the usage of
@default_facts within the unit tests for each module.

Change-Id: Ib3e13535309c14edd8b639b3c05950bb543544f2
2016-01-14 20:55:33 +03:00
Cody Herriges
aba03fb675 Initial msync run for all Puppet OpenStack modules
This patch is the initial modulesync run, it impacts:

* gitignore: just a sync between projects
* gemfile:
  - update and allow to setup facter version and gem source
  - split beaker gems with a dedicated group
  - switch to rspec-puppet 2.2.0
* rakefile:
  - use the new syntax for lint configuration
  - add a acceptance target
* acceptance:
  - sync nodesets
* spec: added rspec coverage report

Change-Id: Ie10f1467374a9c254515172f5ddc53f2e628c602
2015-08-06 20:34:34 +02:00
Gael Chamoulaud
cb436e722e spec: updates for rspec-puppet 2.x and rspec 3.x
This patch aim to update our specs test in order to work with the rspec-puppet
release 2.0.0, in the mean time, we update rspec syntax order to be prepared
for rspec 3.x move.

In details:
* Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
* Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
* Fix spec tests for rspec-puppet 2.0.0
* Clean Gemfile (remove over-specificication of runtime deps of
  puppetlabs_spec_helper)

Change-Id: I405830cd95c9f0635418b91ff081c43d77234e39
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
2015-04-14 11:38:34 +02:00
Mathieu Gagné
d63e437bdf Use concat to manage local_settings.py
Manage local_settings.py content with concat::fragment.

This adds the ability for anyone to add custom fragments
to local_settings.py without having to override the template.

Example on how to use concat::fragment:

  concat::fragment { 'local_settings.py:custom':
    target  => $::horizon::params::config_file,
    content => 'HORIZON_CONFIG["customization_module"] = "my_project.overrides"',
    order   => '90'
  }

The use of puppetlabs-concat does not break backward compatibility
for those establishing relationships with the file resource
that used to be local_settings.py. puppetlabs-concat still declares
a file resource matching the concat resource title when
a concat resource is created.

Closes-bug: #1383500
Change-Id: I97e747c967dddc04b62ff1d31440e42a26dcb3ff
2015-02-09 16:50:28 -05:00
Yanis Guenane
a75b849372 Implement rspec function it_configures
On some puppet modules, a it_configures helper is provided. This commit
implements it for puppet-horizon.

Change-Id: Ic0ca916622ea2ef674d0b0a6d5a907f793c594f3
2014-05-15 15:00:21 -04:00
Mathieu Gagné
4b864789c0 Add ability to disable configuration of apache
Add configure_apache parameter to add the ability to disable
configuration of Apache vhost for Horizon.

- Move Apache configuration to horizon::wsgi::apache class.
- Move management of logdir resource to horizon::wsgi::apache class.

Change-Id: I5aeb577ce827e923ed01a73cca1bd79789f81eff
Closes-bug: #1190282
2014-01-30 16:35:47 -05:00
Branan Purvine-Riley
c386cd4a71 Add initial spec test 2012-06-18 16:12:32 -07:00