From 6009c807f6af8980c4a136199f5cab6bcab9438f Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <kajinamit@oss.nttdata.com>
Date: Mon, 8 Apr 2024 13:22:31 +0900
Subject: [PATCH] Support *_firmware_interface(s) options

Change-Id: I498a6905916efce3d88c1df7e65f38135ae035bf
---
 manifests/drivers/interfaces.pp                    | 14 ++++++++++++++
 .../notes/firmware-interface-77e42d03f54291b9.yaml |  8 ++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 releasenotes/notes/firmware-interface-77e42d03f54291b9.yaml

diff --git a/manifests/drivers/interfaces.pp b/manifests/drivers/interfaces.pp
index 29f4206b..a56635a3 100644
--- a/manifests/drivers/interfaces.pp
+++ b/manifests/drivers/interfaces.pp
@@ -34,6 +34,11 @@
 #   deploy_interface field set.
 #   Defaults to $facts['os_service_default']
 #
+# [*default_firmware_interface*]
+#   (optional) Default deploy interface to be used for nodes that do not have
+#   firmware_interface field set.
+#   Defaults to $facts['os_service_default']
+#
 # [*default_inspect_interface*]
 #   (optional) Default inspect interface to be used for nodes that do not have
 #   inspect_interface field set.
@@ -94,6 +99,11 @@
 #   service initialization.
 #   Defaults to $facts['os_service_default']
 #
+# [*enabled_firmware_interfaces*]
+#   (optional) Specify the list of firmware interfaces to load during
+#   service initialization.
+#   Defaults to $facts['os_service_default']
+#
 # [*enabled_inspect_interfaces*]
 #   (optional) Specify the list of inspect interfaces to load during
 #   service initialization.
@@ -139,6 +149,7 @@ class ironic::drivers::interfaces (
   $default_boot_interface        = $facts['os_service_default'],
   $default_console_interface     = $facts['os_service_default'],
   $default_deploy_interface      = $facts['os_service_default'],
+  $default_firmware_interface    = $facts['os_service_default'],
   $default_inspect_interface     = $facts['os_service_default'],
   $default_management_interface  = $facts['os_service_default'],
   $default_network_interface     = $facts['os_service_default'],
@@ -151,6 +162,7 @@ class ironic::drivers::interfaces (
   $enabled_boot_interfaces       = $facts['os_service_default'],
   $enabled_console_interfaces    = $facts['os_service_default'],
   $enabled_deploy_interfaces     = $facts['os_service_default'],
+  $enabled_firmware_interfaces   = $facts['os_service_default'],
   $enabled_inspect_interfaces    = $facts['os_service_default'],
   $enabled_management_interfaces = $facts['os_service_default'],
   $enabled_network_interfaces    = $facts['os_service_default'],
@@ -170,6 +182,8 @@ class ironic::drivers::interfaces (
                       'default'      => $default_console_interface },
     'deploy'     => { 'enabled_list' => $enabled_deploy_interfaces,
                       'default'      => $default_deploy_interface },
+    'firmware'   => { 'enabled_list' => $enabled_firmware_interfaces,
+                      'default'      => $default_firmware_interface },
     'inspect'    => { 'enabled_list' => $enabled_inspect_interfaces,
                       'default'      => $default_inspect_interface },
     'management' => { 'enabled_list' => $enabled_management_interfaces,
diff --git a/releasenotes/notes/firmware-interface-77e42d03f54291b9.yaml b/releasenotes/notes/firmware-interface-77e42d03f54291b9.yaml
new file mode 100644
index 00000000..36b9ba41
--- /dev/null
+++ b/releasenotes/notes/firmware-interface-77e42d03f54291b9.yaml
@@ -0,0 +1,8 @@
+---
+features:
+  - |
+    The ``ironic::drivers::interfaces`` class now supports the following new
+    parameters.
+
+    - ``enabled_firmware_interfaces``
+    - ``default_firmware_interface``