openstack/puppet-ironic
Code Issues Proposed changes

Allow to set port_setup_delay ironic::conductor param

Browse Source 
This patch allows to configure port_setup_delay by setting
::ironic::config::port_setup_delay variable.

Change-Id: I53548ac2c47296aef5553477a522ab764c2a67bd
This commit is contained in:
Vasyl Saienko 2017-03-28 17:21:52 +03:00
parent 36dd4c1b6f
commit 507d387713
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
manifests/conductor.pp
View File

@ -114,6 +114,11 @@
# Can not be specified together with provisioning_network.
# Defaults to undef, which leaves the configuration intact
#
# [*port_setup_delay*]
# (optional) Delay value to wait for Neutron agents to setup
# sufficient DHCP configuration for port.
# Defaults to $::os_service_default
#
# DEPRECATED
#
# [*cleaning_network_uuid*]
@ -157,6 +162,7 @@ class ironic::conductor (
$configdrive_use_swift = $::os_service_default,
$configdrive_swift_container = $::os_service_default,
$default_boot_option = $::os_service_default,
$port_setup_delay = $::os_service_default,
$cleaning_network_name = undef,
$provisioning_network_name = undef,
# DEPRECATED
@ -261,6 +267,7 @@ moved to ironic::glance manifest")
'conductor/configdrive_use_swift': value => $configdrive_use_swift;
'conductor/configdrive_swift_container': value => $configdrive_swift_container;
'deploy/default_boot_option': value => $default_boot_option;
'neutron/port_setup_delay': value => $port_setup_delay;
}
if $cleaning_network_name {

5
releasenotes/notes/add_port_setup_delay_param-e28595863d31117e.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- Add port_setup_delay parameter to ::ironic::conductor
class. Defines delay value to wait for Neutron agents
to setup sufficient DHCP configuration.

3
spec/classes/ironic_conductor_spec.rb
View File

@ -77,6 +77,7 @@ describe 'ironic::conductor' do
is_expected.to contain_ironic_config('conductor/configdrive_use_swift').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('conductor/configdrive_swift_container').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('deploy/default_boot_option').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('neutron/port_setup_delay').with(:value => '<SERVICE DEFAULT>')
end
context 'when overriding parameters' do
@ -96,6 +97,7 @@ describe 'ironic::conductor' do
:configdrive_use_swift => true,
:configdrive_swift_container => 'cont',
:default_boot_option => 'local',
:port_setup_delay => '15'
)
end
it 'should replace default parameter with new value' do
@ -114,6 +116,7 @@ describe 'ironic::conductor' do
is_expected.to contain_ironic_config('conductor/configdrive_use_swift').with_value(p[:configdrive_use_swift])
is_expected.to contain_ironic_config('conductor/configdrive_swift_container').with_value(p[:configdrive_swift_container])
is_expected.to contain_ironic_config('deploy/default_boot_option').with_value(p[:default_boot_option])
is_expected.to contain_ironic_config('neutron/port_setup_delay').with_value(p[:port_setup_delay])
end
end