openstack/puppet-ironic
Code Issues Proposed changes

Revert "Revert "allow to configure my_ip parameter""

Browse Source 
This reverts commit 5c4d023a77.

Change-Id: Ica0498ae93d77484c26715794d17dccddf0d2771
This commit is contained in:
Emilien Macchi 2016-05-13 14:12:12 +00:00
parent 6dd206cdc3
commit 735c139416
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
manifests/init.pp
View File

@ -37,6 +37,12 @@
# (optional) Print debug messages in the logs
# Defaults to False
#
# [*my_ip*]
# (optional) IP address of this host.
# If unset, will determine the IP programmatically. If unable to do so, will use
# "127.0.0.1".
# Defaults to $::os_service_default.
#
# [*auth_strategy*]
# (optional) Default protocol to use when connecting to glance
# Defaults to 'keystone'. 'https' is the only other valid option for SSL
@ -215,6 +221,7 @@ class ironic (
$package_ensure = 'present',
$verbose = undef,
$debug = undef,
$my_ip = $::os_service_default,
$use_syslog = undef,
$use_stderr = undef,
$log_facility = undef,
@ -311,6 +318,7 @@ class ironic (
ironic_config {
'DEFAULT/auth_strategy': value => $auth_strategy;
'DEFAULT/enabled_drivers': value => join($enabled_drivers, ',');
'DEFAULT/my_ip': value => $my_ip;
'glance/glance_num_retries': value => $glance_num_retries;
'glance/glance_api_insecure': value => $glance_api_insecure;
}

1
spec/classes/ironic_init_spec.rb
View File

@ -120,6 +120,7 @@ describe 'ironic' do
it 'configures ironic.conf' do
is_expected.to contain_ironic_config('DEFAULT/auth_strategy').with_value('keystone')
is_expected.to contain_ironic_config('DEFAULT/my_ip').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('DEFAULT/rpc_response_timeout').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('DEFAULT/control_exchange').with_value('<SERVICE DEFAULT>')
end