openstack
/
puppet-ironic
Code Issues Proposed changes

Fix typos in parameter descriptions, comments and tests 

Change-Id: I4b4671a38e482b74faa4e48ff244c2a08e4b094e
This commit is contained in:
Rajesh Tailor 2022-06-17 18:55:18 +05:30
parent 4564c08992
commit a455ce650c
18 changed files with 28 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/api.pp
View File

@ -20,7 +20,7 @@
# === Parameters
#
# [*package_ensure*]
# (optional) Control the ensure parameter for the package ressource.
# (optional) Control the ensure parameter for the package resource.
# Defaults to 'present'.
#
# [*enabled*]
@ -40,7 +40,7 @@
# [*max_limit*]
# (optional) The maximum number of items returned in a single response
# from a collection resource.
# Should be an valid interger
# Should be an valid integer
# Defaults to '1000'.
#
# [*workers*]

2
manifests/audit.pp
View File

@ -13,7 +13,7 @@
# Defaults to $::os_service_default
#
# [*ignore_req_list*]
# (Optional) Commma separated list of Ironic REST API HTTP methoeds
# (Optional) Comma separated list of Ironic REST API HTTP methods
# to be ignored during audit logging.
# Defaults to $::os_service_default
#

4
manifests/conductor.pp
View File

@ -20,7 +20,7 @@
# === Parameters
#
# [*package_ensure*]
# (optional) Control the ensure parameter for the package ressource.
# (optional) Control the ensure parameter for the package resource.
# Defaults to 'present'.
#
# [*enabled*]
@ -95,7 +95,7 @@
# Defaults to $::os_service_default
#
# [*configdrive_swift_container*]
# (optinal) Swift container to use for storing config drives if
# (optional) Swift container to use for storing config drives if
# configdrive_use_object_store is true.
# Defaults to $::os_service_default
#

2
manifests/deps.pp
View File

@ -52,7 +52,7 @@ class ironic::deps {
# Support packages need to be installed in the install phase, but we don't
# put them in the chain above because we don't want any false dependencies
# between packages with the ironic-package tag and the ironic-support-package
# tag. Note: the package resources here will have a 'before' relationshop on
# tag. Note: the package resources here will have a 'before' relationship on
# the ironic::install::end anchor. The line between ironic-support-package and
# ironic-package should be whether or not ironic services would need to be
# restarted if the package state was changed.

2
manifests/drivers/agent.pp
View File

@ -28,7 +28,7 @@
#
# [*post_deploy_get_power_state_retries*]
# (optional) Number of retries getting power state after a soft power off.
# Must be a valid interger.
# Must be a valid integer.
# Defaults to $::os_service_default
#
# [*post_deploy_get_power_state_retry_interval*]

2
manifests/drivers/ilo.pp
View File

@ -16,7 +16,7 @@
#
# [*client_timeout*]
# (optional) Maximum time in seconds to wait for iLO commands.
# Should be an interger value
# Should be an integer value
# Defaults to $::os_service_default.
#
# [*client_port*]

6
manifests/drivers/ipmi.pp
View File

@ -21,12 +21,12 @@
#
# [*command_retry_timeout*]
# (optional) Maximum time in seconds to retry IPMI operations.
# Should be an interger value
# Should be an integer value
# Defaults to $::os_service_default
#
# [*min_command_interval*]
# (optional) Minimum time, in seconds, between IPMI operations.
# Should be an interger value
# Should be an integer value
# Defaults to $::os_service_default
#
# [*use_ipmitool_retries*]
@ -38,7 +38,7 @@
# Defaults to $::os_service_default
#
# [*disable_boot_timeout*]
# (optional) Whether ironic sends a raw IPMI command to dsiable the 60 second
# (optional) Whether ironic sends a raw IPMI command to disable the 60 second
# timeout for booting.
# Defaults to $::os_service_default
#

2
manifests/drivers/pxe.pp
View File

@ -203,7 +203,7 @@ Use the kernel_append_params parameter instead')
}
if $enable_ppc64le {
# FXIME(tonyb): As these are really hash values it would beter to model
# FXIME(tonyb): As these are really hash values it would be better to model
# them that way. We can do that later, probably when we add another
# architecture
ironic_config {

4
manifests/drivers/redfish.pp
View File

@ -37,7 +37,7 @@
# Defaults to $::os_service_default.
#
# [*use_swift*]
# (optional) Upload genrated ISO images for virtual media boot to Swift.
# (optional) Upload generated ISO images for virtual media boot to Swift.
# Defaults to $::os_service_default.
#
# [*swift_container*]
@ -49,7 +49,7 @@
# Defaults to $::os_service_default.
#
# [*kernel_append_params*]
# (optional) Addiitonal kernel parameters to pass down to the instance kernel
# (optional) Additional kernel parameters to pass down to the instance kernel
# Defaults to $::os_service_default.
#
# [*file_permission*]

4
manifests/healthcheck.pp
View File

@ -18,12 +18,12 @@
# Defaults to $::os_service_default
#
# [*disable_by_file_path*]
# (Optional) Check the presense of a file to determine if an application
# (Optional) Check the presence of a file to determine if an application
# is running on a port.
# Defaults to $::os_service_default
#
# [*disable_by_file_paths*]
# (Optional) Check the presense of a file to determine if an application
# (Optional) Check the presence of a file to determine if an application
# is running on a port. Expects a "port:path" list of strings.
# Defaults to $::os_service_default
#

8
manifests/inspector.pp
View File

@ -32,7 +32,7 @@
#
# [*pxe_transfer_protocol*]
# (optional) Protocol preferred for transferring the ramdisk.
# Some archtecture require tftp is used exclusively.
# Some architecture require tftp is used exclusively.
# Defaults to 'tftp'. Valid values are 'tftp' or 'http'.
#
# [*dhcp_debug*]
@ -49,7 +49,7 @@
# Defaults to $::os_service_default
#
# [*api_max_limit*]
# (optional) Limit the numer of elements an API list-call returns
# (optional) Limit the number of elements an API list-call returns
# Defaults to $::os_service_default
#
# [*dnsmasq_interface*]
@ -171,7 +171,7 @@
# Defaults to $::os_service_default
#
# [*enable_ppc64le*]
# (optional) Boolean value to dtermine if ppc64le support should be enabled
# (optional) Boolean value to determine if ppc64le support should be enabled
# Defaults to false (no ppc64le support)
#
# [*default_transport_url*]
@ -317,7 +317,7 @@ class ironic::inspector (
#Processing hooks string
#Moved here in favor of removing the
#140 chars exeeded error in puppet-lint
#140 chars exceeded error in puppet-lint
$p_hooks = join(delete_undef_values(['$default_processing_hooks', $additional_processing_hooks]), ',')
# Convert the hash to comma separated string of <key>:<value> pairs.

4
manifests/inspector/healthcheck.pp
View File

@ -18,12 +18,12 @@
# Defaults to $::os_service_default
#
# [*disable_by_file_path*]
# (Optional) Check the presense of a file to determine if an application
# (Optional) Check the presence of a file to determine if an application
# is running on a port.
# Defaults to $::os_service_default
#
# [*disable_by_file_paths*]
# (Optional) Check the presense of a file to determine if an application
# (Optional) Check the presence of a file to determine if an application
# is running on a port. Expects a "port:path" list of strings.
# Defaults to $::os_service_default
#

2
manifests/keystone/auth.pp
View File

@ -77,7 +77,7 @@
# Defaults to 'RegionOne'.
#
# [*public_url*]
# (0ptional) The endpoint's public url.
# (Optional) The endpoint's public url.
# This url should *not* contain any trailing '/'.
# Defaults to 'http://127.0.0.1:6385'
#

2
manifests/logging.pp
View File

@ -69,7 +69,7 @@
# See https://docs.python.org/2/howto/logging.html
#
# [*default_log_levels*]
# (0ptional) Hash of logger (keys) and level (values) pairs.
# (Optional) Hash of logger (keys) and level (values) pairs.
# Defaults to $::os_service_default
# Example:
# { 'amqp' => 'WARN', 'amqplib' => 'WARN', 'boto' => 'WARN',

2
manifests/pxe/tftpboot_file.pp
View File

@ -13,7 +13,7 @@
# License for the specific language governing permissions and limitations
# under the License.
# Internal define for coyping tftpboot files
# Internal define for copying tftpboot files
#
# === Parameters
#

2
manifests/wsgi/apache.pp
View File

@ -79,7 +79,7 @@
# Optional. Defaults to undef.
#
# [*custom_wsgi_process_options*]
# (optional) gives you the oportunity to add custom process options or to
# (optional) gives you the opportunity to add custom process options or to
# overwrite the default options for the WSGI main process.
# eg. to use a virtual python environment for the WSGI process
# you could set it to:

2
spec/classes/ironic_audit_spec.rb
View File

@ -39,7 +39,7 @@ describe 'ironic::audit' do
}
end
it 'configures ignore_req_list with a comma separeted list' do
it 'configures ignore_req_list with a comma separated list' do
is_expected.to contain_ironic_config('audit/ignore_req_list').with_value('GET,POST')
end
end

2
spec/classes/ironic_inspector_db_sync_spec.rb
View File

@ -6,7 +6,7 @@ describe 'ironic::inspector::db::sync' do
it { is_expected.to contain_class('ironic::deps') }
it 'runs ironic-inspectror-db_sync' do
it 'runs ironic-inspector-db_sync' do
is_expected.to contain_exec('ironic-inspector-dbsync').with(
:command => 'ironic-inspector-dbsync --config-file /etc/ironic-inspector/inspector.conf upgrade',
:path => '/usr/bin',