openstack/puppet-ironic
Code Issues Proposed changes

Expose the versioned_notifications_topics param

Browse Source 
After merging https://review.openstack.org/#/c/629818
versioned_notifications_topics are unconfigurable. This
patch exposes this parameter to allow its customization.

Change-Id: I230585a73f0c50ac1a3a14d678071e6088634f1b
This commit is contained in:
Daniel Abad 2019-02-01 16:24:33 +01:00
parent c759515301
commit b7d5ee6c78
3 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
manifests/init.pp
View File

@ -253,6 +253,10 @@
# (optional) Notification level for outgoing notifications # (optional) Notification level for outgoing notifications
# Defaults to $::os_service_default # Defaults to $::os_service_default
# #
# [*versioned_notifications_topics*]
# (optional) Topics for the versioned notifications issued by Ironic
# Defaults to $::os_service_default
#
class ironic ( class ironic (
$enabled = true, $enabled = true,
$package_ensure = 'present', $package_ensure = 'present',
@ -306,6 +310,7 @@ class ironic (
$notification_driver = $::os_service_default, $notification_driver = $::os_service_default,
$notification_topics = $::os_service_default, $notification_topics = $::os_service_default,
$notification_level = $::os_service_default, $notification_level = $::os_service_default,
$versioned_notifications_topics = $::os_service_default,
) { ) {
include ::ironic::deps include ::ironic::deps
@ -331,10 +336,11 @@ class ironic (
} }
ironic_config { ironic_config {
'DEFAULT/auth_strategy': value => $auth_strategy; 'DEFAULT/auth_strategy': value => $auth_strategy;
'DEFAULT/my_ip': value => $my_ip; 'DEFAULT/my_ip': value => $my_ip;
'DEFAULT/default_resource_class': value => $default_resource_class; 'DEFAULT/default_resource_class': value => $default_resource_class;
'DEFAULT/notification_level': value => $notification_level; 'DEFAULT/notification_level': value => $notification_level;
'DEFAULT/versioned_notifications_topics': value => $versioned_notifications_topics;
} }
if $sync_db { if $sync_db {

4
releasenotes/notes/add-versioned-notifications-topics-d3dc07b1338edd6a.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
Expose the ``versioned_notifications_topics`` parameter in ``::ironic``

1
spec/classes/ironic_init_spec.rb
View File

@ -109,6 +109,7 @@ describe 'ironic' do
is_expected.to contain_ironic_config('DEFAULT/transport_url').with_value('<SERVICE DEFAULT>').with_secret(true) is_expected.to contain_ironic_config('DEFAULT/transport_url').with_value('<SERVICE DEFAULT>').with_secret(true)
is_expected.to contain_ironic_config('DEFAULT/default_resource_class').with_value('<SERVICE DEFAULT>') is_expected.to contain_ironic_config('DEFAULT/default_resource_class').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('DEFAULT/notification_level').with_value('<SERVICE DEFAULT>') is_expected.to contain_ironic_config('DEFAULT/notification_level').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('DEFAULT/versioned_notifications_topics').with_value('<SERVICE DEFAULT>')
end end
end end