openstack/puppet-ironic
Code Issues Proposed changes

Remove wrong TODO comment

Browse Source 
The IPAddr.new().prefix function does not work as intended. This change
removes the TODO comment to use the function because we can't really
replace the current implementation by that built-in feature.

irb(main):001:0> IPAddr.new('ffff:ffff:ffff:ffff::').to_i.to_s(2).count("1")
=> 64
irb(main):002:0> IPAddr.new('ffff:ffff:ffff:ffff::').prefix
=> 128

Change-Id: I07a340e1716f6ab8db718b89bf4535f989df7929
This commit is contained in:
Takashi Kajinami 2022-08-25 10:33:04 +09:00
parent 3213f8e2df
commit c4c5372851
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/puppet/functions/ipv6_normalize_dnsmasq_ip_subnets.rb
View File

@ -7,8 +7,6 @@ Puppet::Functions.create_function(:ipv6_normalize_dnsmasq_ip_subnets) do
begin
if ip_subnet["netmask"]
if IPAddr.new(ip_subnet["netmask"]).ipv6?
# TODO(hjensas) Once we have ruby stdlib >= 2.5.x we can use
# IPAddr.new().prefix instead of counting 1's.
prefix = IPAddr.new(ip_subnet["netmask"]).to_i.to_s(2).count("1")
Puppet.debug("Netmask #{ip_subnet["netmask"]} changed to prefix #{prefix}")
ip_subnet_dup["netmask"] = prefix