Add support for the oslo_policy/enforce_scope parameter

Depends-on: https://review.opendev.org/#/c/759008/
Change-Id: Ia28b3de3c5061d0407591a1c9053292ca3e04fb2
This commit is contained in:
Takashi Kajinami 2021-03-16 17:20:26 +09:00
parent 78bd0aee93
commit dfe8cd4783
3 changed files with 24 additions and 10 deletions

View File

@ -4,6 +4,10 @@
# #
# === Parameters # === Parameters
# #
# [*enforce_scope*]
# (Optional) Whether or not to enforce scope when evaluating policies.
# Defaults to $::os_service_default.
#
# [*policies*] # [*policies*]
# (Optional) Set of policies to configure for ironic # (Optional) Set of policies to configure for ironic
# Example : # Example :
@ -24,8 +28,9 @@
# Defaults to /etc/ironic/policy.yaml # Defaults to /etc/ironic/policy.yaml
# #
class ironic::policy ( class ironic::policy (
$policies = {}, $enforce_scope = $::os_service_default,
$policy_path = '/etc/ironic/policy.yaml', $policies = {},
$policy_path = '/etc/ironic/policy.yaml',
) { ) {
include ironic::deps include ironic::deps
@ -42,6 +47,9 @@ class ironic::policy (
create_resources('openstacklib::policy::base', $policies) create_resources('openstacklib::policy::base', $policies)
oslo::policy { 'ironic_config': policy_file => $policy_path } oslo::policy { 'ironic_config':
enforce_scope => $enforce_scope,
policy_file => $policy_path
}
} }

View File

@ -0,0 +1,5 @@
---
features:
- |
The new ``ironic::policy::enforce_scope`` parameter has been added to
support the corresponding parameter in oslo.policy library.

View File

@ -1,12 +1,12 @@
require 'spec_helper' require 'spec_helper'
describe 'ironic::policy' do describe 'ironic::policy' do
shared_examples 'ironic::policy' do
shared_examples_for 'ironic policies' do
let :params do let :params do
{ {
:policy_path => '/etc/ironic/policy.yaml', :enforce_scope => false,
:policies => { :policy_path => '/etc/ironic/policy.yaml',
:policies => {
'context_is_admin' => { 'context_is_admin' => {
'key' => 'context_is_admin', 'key' => 'context_is_admin',
'value' => 'foo:bar' 'value' => 'foo:bar'
@ -24,20 +24,21 @@ describe 'ironic::policy' do
:file_format => 'yaml', :file_format => 'yaml',
}) })
is_expected.to contain_oslo__policy('ironic_config').with( is_expected.to contain_oslo__policy('ironic_config').with(
:policy_file => '/etc/ironic/policy.yaml', :enforce_scope => false,
:policy_file => '/etc/ironic/policy.yaml',
) )
end end
end end
on_supported_os({ on_supported_os({
:supported_os => OSDefaults.get_supported_os :supported_os => OSDefaults.get_supported_os
}).each do |os,facts| }).each do |os,facts|
context "on #{os}" do context "on #{os}" do
let (:facts) do let (:facts) do
facts.merge!(OSDefaults.get_facts()) facts.merge!(OSDefaults.get_facts())
end end
it_configures 'ironic policies' it_behaves_like 'ironic::policy'
end end
end end
end end