openstack
/
puppet-ironic
Code Issues Proposed changes

Update patch set 17 

Patch Set 17:

(1 comment)

Thanks for the review Sebastien.  I left a response inline.

Patch-set: 17
Label: Verified=0
This commit is contained in:
Gerrit User 10419 2015-01-13 14:50:18 +00:00 committed by Gerrit Code Review
parent edba3e7f66
commit f819fea37a
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
a34629f956c97fb99fd1a9fc74127db970d53e12
View File

@ -50,6 +50,24 @@
"revId": "a34629f956c97fb99fd1a9fc74127db970d53e12",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a961159_40fdc907",
"filename": "manifests/init.pp",
"patchSetId": 17
},
"lineNbr": 185,
"author": {
"id": 10419
},
"writtenOn": "2015-01-13T14:50:18Z",
"side": 0,
"message": "I can\u0027t find the Ironic equivalent to this. The only mysql classes I can find are for \u0027mysql::server\u0027 and \u0027mysql::ruby\u0027. Given this, I think the \u0027mysql::python\u0027 class is no longer relevant. Either way, its absence doesn\u0027t affect functionality.",
"parentUuid": "3a961159_ce2e66ab",
"revId": "a34629f956c97fb99fd1a9fc74127db970d53e12",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}