puppet-ironic/2251843ae56c0399831f21234df9540d43809284

{
  "comments": [
    {
      "key": {
        "uuid": "3a961159_b3529766",
        "filename": "/COMMIT_MSG",
        "patchSetId": 7
      },
      "lineNbr": 23,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-15T20:54:00Z",
      "side": 1,
      "message": "why?",
      "revId": "2251843ae56c0399831f21234df9540d43809284",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_5316d3a8",
        "filename": "manifests/init.pp",
        "patchSetId": 7
      },
      "lineNbr": 176,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-15T20:54:00Z",
      "side": 1,
      "message": "* Why do you need this package?\n* We don\u0027t fix packaging dependencies issues in our Puppet modules, rather in upstream packages. If python-bpr is a dependency, please fix packaging to make it happen.",
      "revId": "2251843ae56c0399831f21234df9540d43809284",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_365db5ed",
        "filename": "manifests/init.pp",
        "patchSetId": 7
      },
      "lineNbr": 176,
      "author": {
        "id": 10419
      },
      "writtenOn": "2014-12-15T21:10:23Z",
      "side": 1,
      "message": "I ran into the issue once the rdo release repo changed to Juno.\n\nGood point and I agree, but this is just a guarantee that it\u0027s installed.  I came to the conclusion to do it this way because Nova requires packages like \u0027libvirt\u0027 \u0027numpy\u0027 \u0027scsi-target-utils\u0027.  So I figured I would do it the same way.",
      "parentUuid": "3a961159_5316d3a8",
      "revId": "2251843ae56c0399831f21234df9540d43809284",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_d677113a",
        "filename": "manifests/init.pp",
        "patchSetId": 7
      },
      "lineNbr": 176,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-15T21:17:29Z",
      "side": 1,
      "message": "fair enough. Just please make sure the dependency will be fixed in Kilo and if not please create a bugzilla (or something in the bugstracker of the distro). Also add the bug URL in the manifest to drop it later.",
      "parentUuid": "3a961159_365db5ed",
      "revId": "2251843ae56c0399831f21234df9540d43809284",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_337867f8",
        "filename": "manifests/init.pp",
        "patchSetId": 7
      },
      "lineNbr": 181,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-15T20:54:00Z",
      "side": 1,
      "message": "You could have left ironic here, like we do in other modules.",
      "revId": "2251843ae56c0399831f21234df9540d43809284",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_1630b9e7",
        "filename": "manifests/init.pp",
        "patchSetId": 7
      },
      "lineNbr": 181,
      "author": {
        "id": 10419
      },
      "writtenOn": "2014-12-15T21:10:23Z",
      "side": 1,
      "message": "I could if you want to.  I actually copied the idea from Nova which does:\n  \n  file { \u0027/etc/nova/nova.conf\u0027:\n    mode    \u003d\u003e \u00270640\u0027,\n    owner   \u003d\u003e \u0027nova\u0027,\n    group   \u003d\u003e \u0027nova\u0027,\n    require \u003d\u003e Package[\u0027nova-common\u0027],\n  }",
      "parentUuid": "3a961159_337867f8",
      "revId": "2251843ae56c0399831f21234df9540d43809284",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_16727949",
        "filename": "manifests/init.pp",
        "patchSetId": 7
      },
      "lineNbr": 181,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-15T21:17:29Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "3a961159_1630b9e7",
      "revId": "2251843ae56c0399831f21234df9540d43809284",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}