puppet-ironic/e6ce348f97af838db424a6b29b3cb6a4257e595d

{
  "comments": [
    {
      "key": {
        "uuid": "3a961159_e0505c0c",
        "filename": "/COMMIT_MSG",
        "patchSetId": 10
      },
      "lineNbr": 21,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-18T14:24:37Z",
      "side": 1,
      "message": "You don\u0027t mention in your commit message on the provider to get the tenant id.",
      "revId": "e6ce348f97af838db424a6b29b3cb6a4257e595d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_60aaacd3",
        "filename": "lib/puppet/provider/ironic_admin_tenant_id_setter/ini_setting.rb",
        "patchSetId": 10
      },
      "lineNbr": 169,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-18T14:24:37Z",
      "side": 1,
      "message": "You can\u0027t get multiple tenant ID (btw, drop name here).\n\nPlease fix your copy/paste here, because we get an ID now :-)",
      "revId": "e6ce348f97af838db424a6b29b3cb6a4257e595d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_60bf0cfd",
        "filename": "lib/puppet/provider/ironic_admin_tenant_id_setter/ini_setting.rb",
        "patchSetId": 10
      },
      "lineNbr": 179,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-18T14:24:37Z",
      "side": 1,
      "message": "and if we don\u0027t use swift?\n\nI see what you want to do here but the problem is your design enforce to use Swift backend, that is not flexible enough.",
      "revId": "e6ce348f97af838db424a6b29b3cb6a4257e595d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_806cf89d",
        "filename": "manifests/api.pp",
        "patchSetId": 10
      },
      "lineNbr": 138,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-18T14:24:37Z",
      "side": 1,
      "message": "not flexible, what about if I don\u0027t use Swift?",
      "revId": "e6ce348f97af838db424a6b29b3cb6a4257e595d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_2013440e",
        "filename": "manifests/api.pp",
        "patchSetId": 10
      },
      "lineNbr": 147,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-18T14:24:37Z",
      "side": 1,
      "message": "why did you move it?",
      "revId": "e6ce348f97af838db424a6b29b3cb6a4257e595d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_6090ec4e",
        "filename": "manifests/api.pp",
        "patchSetId": 10
      },
      "lineNbr": 162,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-18T14:24:37Z",
      "side": 1,
      "message": "so each time ironic config will change, we will upload a new key to Swift temp-url?",
      "revId": "e6ce348f97af838db424a6b29b3cb6a4257e595d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_407cd020",
        "filename": "manifests/init.pp",
        "patchSetId": 10
      },
      "lineNbr": 159,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-18T14:24:37Z",
      "side": 1,
      "message": "this is not useful since we have package { name \u003d\u003e real_name_in_params } to ensure we have the right package name.",
      "revId": "e6ce348f97af838db424a6b29b3cb6a4257e595d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_e0921c4a",
        "filename": "manifests/init.pp",
        "patchSetId": 10
      },
      "lineNbr": 161,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-18T14:24:37Z",
      "side": 1,
      "message": "I even think this directly is useless in this manifest, since it\u0027s managed by packaging. I put it because I\u0027ve seen that in other modules. I think we should drop it.",
      "revId": "e6ce348f97af838db424a6b29b3cb6a4257e595d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a961159_20eb44b1",
        "filename": "manifests/init.pp",
        "patchSetId": 10
      },
      "lineNbr": 176,
      "author": {
        "id": 3153
      },
      "writtenOn": "2014-12-18T14:24:37Z",
      "side": 1,
      "message": "If pbr is a dependency not solved in upstream packaging, please:\n\n* report the issue in upstream bugtrackers\n* put the bugtrack URL in comment as TODO, then later we can drop this puppet code that should not reside here.\n\nWhy ? Because OpenStack Puppet modules should not manage packaging dependencies issues, and let packaging doing it.\nAlso, we want to avoid any conflict with other manifests, and having duplicated resources.",
      "revId": "e6ce348f97af838db424a6b29b3cb6a4257e595d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}