openstack/puppet-keystone
Code Issues Proposed changes

endpoint: stop sending warning if $version is not empty

Browse Source 
No all OpenStack clients & Tempest[1] actually support versionless
endpoints, that's why we need to wait more before changing the default
value.

This patch aims to:
* document why we keep to set a version by default
* stop to show a warning when not setting empty.

Setting the $version to empty is at the risk of the deployer, and note
that it could lead to issues with some OpenStack clients & Tempest.

[1] https://review.openstack.org/#/q/status:open+project:openstack/tempest-lib+branch:master+topic:bug/1530181

Change-Id: Ie2c8070411d403bfcd372665462922db077ee961
This commit is contained in:
Emilien Macchi 2016-01-08 11:50:41 -05:00
parent 021c737e1c
commit 0f9b25d71f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/endpoint.pp
View File

@ -63,7 +63,11 @@ class keystone::endpoint (
) {
if $version == 'unset' {
warning('In Mitaka, the default value of $keystone::endpoint::version will change to \'\'. To avoid this warning, please set the version parameter.')
# $version will be set to empty '' once tempest & all openstack clients
# actually support versionless endpoints.
# See ongoing work in Tempest:
# https://review.openstack.org/#/q/status:open+project:openstack/tempest-lib+branch:master+topic:bug/1530181
# Until that, we need to set a version by default.
$_version = 'v2.0'
} else {
$_version = $version