diff --git a/manifests/cache.pp b/manifests/cache.pp index 68b716527..c3d39963d 100644 --- a/manifests/cache.pp +++ b/manifests/cache.pp @@ -275,4 +275,7 @@ class keystone::cache( manage_backend_package => $manage_backend_package, } + # all cache settings should be applied and all packages should be installed + # before service startup + Oslo::Cache['keystone_config'] -> Anchor['keystone::service::begin'] } diff --git a/manifests/db.pp b/manifests/db.pp index f4a3a9fd2..d21cafbde 100644 --- a/manifests/db.pp +++ b/manifests/db.pp @@ -69,4 +69,7 @@ class keystone::db ( mysql_enable_ndb => $mysql_enable_ndb, } + # all db settings should be applied and all packages should be installed + # before dbsync starts + Oslo::Db['keystone_config'] -> Anchor['keystone::dbsync::begin'] } diff --git a/manifests/deps.pp b/manifests/deps.pp index 677fa2d18..1091d2e0c 100644 --- a/manifests/deps.pp +++ b/manifests/deps.pp @@ -24,22 +24,8 @@ class keystone::deps { ~> Service<| tag == 'keystone-service' |> ~> anchor { 'keystone::service::end': } - # On any uwsgi config change, we must restart Keystone. Anchor['keystone::config::begin'] -> Keystone_uwsgi_config<||> - ~> Anchor['keystone::config::end'] - - # all cache settings should be applied and all packages should be installed - # before service startup - Oslo::Cache<||> -> Anchor['keystone::service::begin'] - - # all db settings should be applied and all packages should be installed - # before dbsync starts - Oslo::Db<||> -> Anchor['keystone::dbsync::begin'] - - # policy config should occur in the config block also. - Anchor['keystone::config::begin'] - -> Openstacklib::Policy<| tag == 'keystone' |> -> Anchor['keystone::config::end'] # Support packages need to be installed in the install phase, but we don't diff --git a/manifests/init.pp b/manifests/init.pp index 56d4840c0..d0c3180b4 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -548,6 +548,9 @@ class keystone( hasrestart => true, tag => 'keystone-service', } + + # On any uwsgi config change, we must restart Keystone. + Keystone_uwsgi_config<||> ~> Service['keystone'] } 'httpd': { include apache::params diff --git a/manifests/policy.pp b/manifests/policy.pp index d0edbf43b..ffd639cf9 100644 --- a/manifests/policy.pp +++ b/manifests/policy.pp @@ -65,11 +65,15 @@ class keystone::policy ( file_group => $::keystone::params::group, file_format => 'yaml', purge_config => $purge_config, - tag => 'keystone', } create_resources('openstacklib::policy', { $policy_path => $policy_parameters }) + # policy config should occur in the config block also. + Anchor['keystone::config::begin'] + -> Openstacklib::Policy[$policy_path] + -> Anchor['keystone::config::end'] + oslo::policy { 'keystone_config': enforce_scope => $enforce_scope, enforce_new_defaults => $enforce_new_defaults, diff --git a/spec/classes/keystone_policy_spec.rb b/spec/classes/keystone_policy_spec.rb index 45c7eb03b..0f35f849a 100644 --- a/spec/classes/keystone_policy_spec.rb +++ b/spec/classes/keystone_policy_spec.rb @@ -33,7 +33,6 @@ describe 'keystone::policy' do :file_group => 'keystone', :file_format => 'yaml', :purge_config => false, - :tag => 'keystone', ) is_expected.to contain_oslo__policy('keystone_config').with( :enforce_scope => false, @@ -64,7 +63,6 @@ describe 'keystone::policy' do :file_group => 'keystone', :file_format => 'yaml', :purge_config => true, - :tag => 'keystone', ) is_expected.to contain_oslo__policy('keystone_config').with( :enforce_scope => false,