openstack
/
puppet-keystone
Code Issues Proposed changes

Check length of unique array in roles::admin 

When the default values for this class is used it
will try to create keystone_domain resources while
the $domains variable equals to [] causing a Puppet
error.

Depends-On: https://review.opendev.org/c/789816
Change-Id: I7f53aebb0f6ee1130fcd99b45b8dc4031a8b456c
This commit is contained in:
Tobias Urdin 2021-05-04 09:54:27 +02:00
parent 247cade883
commit 37fd0cd0f7
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
manifests/roles/admin.pp
View File

@ -106,9 +106,11 @@ class keystone::roles::admin(
}
$domains = unique(delete_undef_values([ $admin_user_domain, $admin_project_domain, $service_project_domain, $target_admin_domain]))
keystone_domain { $domains:
ensure => present,
enabled => true,
if length($domains) > 0 {
keystone_domain { $domains:
ensure => present,
enabled => true,
}
}
keystone_tenant { $service_tenant: