openstack/puppet-keystone
Code Issues Proposed changes

Fix outdated default of [ldap] use(_auth)_pool

Browse Source 
Since Newton release, Keystone enables connection pools for LDAP access
by default[1]. This change fixes the out-dated default.

[1] 22b114f64724a551df5d32075b6a2d93c394b0d3

Closes-Bug: #1966597
Change-Id: I29d7ba712f45a62ac64b915b2b3e0197cad9179b
This commit is contained in:
Takashi Kajinami 2022-03-28 01:41:33 +09:00
parent c2525c6e63
commit 5f35ea8edd
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
manifests/ldap.pp
View File

@ -184,7 +184,7 @@
# #
# [*use_pool*] # [*use_pool*]
# Enable LDAP connection pooling. (boolean value) # Enable LDAP connection pooling. (boolean value)
# Defaults to false # Defaults to true
# #
# [*pool_size*] # [*pool_size*]
# Connection pool size. (integer value) # Connection pool size. (integer value)
@ -209,7 +209,7 @@
# [*use_auth_pool*] # [*use_auth_pool*]
# Enable LDAP connection pooling for end user authentication. # Enable LDAP connection pooling for end user authentication.
# If use_pool is disabled, then this setting is meaningless and is not used at all. (boolean value) # If use_pool is disabled, then this setting is meaningless and is not used at all. (boolean value)
# Defaults to false # Defaults to true
# #
# [*auth_pool_size*] # [*auth_pool_size*]
# End user auth connection pool size. (integer value) # End user auth connection pool size. (integer value)
@ -288,13 +288,13 @@ class keystone::ldap(
$identity_driver = undef, $identity_driver = undef,
$assignment_driver = undef, $assignment_driver = undef,
$credential_driver = undef, $credential_driver = undef,
$use_pool = false, $use_pool = true,
$pool_size = 10, $pool_size = 10,
$pool_retry_max = 3, $pool_retry_max = 3,
$pool_retry_delay = 0.1, $pool_retry_delay = 0.1,
$pool_connection_timeout = -1, $pool_connection_timeout = -1,
$pool_connection_lifetime = 600, $pool_connection_lifetime = 600,
$use_auth_pool = false, $use_auth_pool = true,
$auth_pool_size = 100, $auth_pool_size = 100,
$auth_pool_connection_lifetime = 60, $auth_pool_connection_lifetime = 60,
$package_ensure = present, $package_ensure = present,

5
releasenotes/notes/bug-1966597-1e6eb4f2911dbe23.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- |
Now the ``keystone::ldap`` class enables connection pools for LDAP access
by default.