openstack/puppet-keystone
Code Issues Proposed changes

Add test coverage for keystone::db::mysql

Browse Source 
Currently most of the tests in keystone_db_mysql_spec.rb aren't checking
anything, they're just setting up the framework. This patch will add test
coverage for mysql.

Change-Id: Ieb497d7ebeb0ddc145a53548500b02fbc10399ca
This commit is contained in:
Nate Potter 2015-11-16 17:10:17 +00:00
parent 0f7c194f01
commit 7c754b89b5
1 changed files with 37 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
spec/classes/keystone_db_mysql_spec.rb
View File

@ -15,18 +15,18 @@ describe 'keystone::db::mysql' do
let :params do
{
'password' => 'keystone_default_password',
:password => 'keystone_default_password',
}
end
describe 'with only required params' do
it { is_expected.to contain_openstacklib__db__mysql('keystone').with(
'user' => 'keystone',
'password_hash' => '*B552157B14BCEDDCEAA06767A012F31BDAA9CE3D',
'dbname' => 'keystone',
'host' => '127.0.0.1',
'charset' => 'utf8',
:collate => 'utf8_general_ci',
:user => 'keystone',
:password_hash => '*B552157B14BCEDDCEAA06767A012F31BDAA9CE3D',
:dbname => 'keystone',
:host => '127.0.0.1',
:charset => 'utf8',
:collate => 'utf8_general_ci',
)}
end
@ -38,6 +38,16 @@ describe 'keystone::db::mysql' do
}
end
it { is_expected.to contain_openstacklib__db__mysql('keystone').with(
:user => 'keystone',
:password_hash => '*706BFA85E15D0C1D8467D0D81D784F6A04CE4ABB',
:dbname => 'keystone',
:host => '127.0.0.1',
:charset => 'utf8',
:collate => 'utf8_general_ci',
:allowed_hosts => ['127.0.0.1','%'],
)}
end
describe "overriding allowed_hosts param to string" do
let :params do
@ -47,6 +57,16 @@ describe 'keystone::db::mysql' do
}
end
it { is_expected.to contain_openstacklib__db__mysql('keystone').with(
:user => 'keystone',
:password_hash => '*47651CDAAB340A79CC838378072877FFFBF0B239',
:dbname => 'keystone',
:host => '127.0.0.1',
:charset => 'utf8',
:collate => 'utf8_general_ci',
:allowed_hosts => '192.168.1.1',
)}
end
describe "overriding allowed_hosts param equals to host param " do
@ -57,6 +77,16 @@ describe 'keystone::db::mysql' do
}
end
it { is_expected.to contain_openstacklib__db__mysql('keystone').with(
:user => 'keystone',
:password_hash => '*47651CDAAB340A79CC838378072877FFFBF0B239',
:dbname => 'keystone',
:host => '127.0.0.1',
:charset => 'utf8',
:collate => 'utf8_general_ci',
:allowed_hosts => '127.0.0.1',
)}
end
end