openstack
/
puppet-keystone
Code Issues Proposed changes

Add use_journal option for logging configuration 

This enables oslo.log to pass logging records to journald.

Depends-On: I2f2977d88607939c278815cc449a129e8c04379d
Change-Id: I5b8393e0d290f325e1de910f30561a7b08abe7d6
This commit is contained in:
Juan Antonio Osorio Robles 2017-09-29 14:50:33 +03:00
parent 373d84d879
commit aabe420a3f
3 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/logging.pp
View File

@ -12,6 +12,10 @@
# (Optional) Use syslog for logging.
# Defaults to $::os_service_default
#
# [*use_journal*]
# (Optional) Use journal for logging.
# Defaults to $::os_service_default
#
# [*use_stderr*]
# (optional) Use stderr for logging
# Defaults to $::os_service_default
@ -104,6 +108,7 @@
#
class keystone::logging(
$use_syslog = $::os_service_default,
$use_journal = $::os_service_default,
$use_stderr = $::os_service_default,
$log_facility = $::os_service_default,
$log_dir = '/var/log/keystone',
@ -143,6 +148,7 @@ class keystone::logging(
log_dir => $log_dir_real,
watch_log_file => $watch_log_file,
use_syslog => $use_syslog_real,
use_journal => $use_journal,
syslog_log_facility => $log_facility_real,
use_stderr => $use_stderr_real,
logging_context_format_string => $logging_context_format_string,

5
releasenotes/notes/Add-use_journal-option-for-logging-7eeca0fccb658f3a.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
Adds the use_journal option for configuring oslo.log. This will enable
passing the logs to journald.

13
spec/classes/keystone_logging_spec.rb
View File

@ -24,6 +24,7 @@ describe 'keystone::logging' do
:instance_uuid_format => '[instance: %(uuid)s] ',
:log_date_format => '%Y-%m-%d %H:%M:%S',
:use_syslog => true,
:use_journal => true,
:use_stderr => false,
:log_facility => 'LOG_FOO',
:log_dir => '/var/log',
@ -57,11 +58,12 @@ describe 'keystone::logging' do
shared_examples 'basic default logging settings' do
it 'configures keystone logging settings with default values' do
is_expected.to contain_oslo__log('keystone_config').with(
:use_syslog => '<SERVICE DEFAULT>',
:use_stderr => '<SERVICE DEFAULT>',
:log_dir => '/var/log/keystone',
:log_file => '<SERVICE DEFAULT>',
:debug => '<SERVICE DEFAULT>',
:use_syslog => '<SERVICE DEFAULT>',
:use_journal => '<SERVICE DEFAULT>',
:use_stderr => '<SERVICE DEFAULT>',
:log_dir => '/var/log/keystone',
:log_file => '<SERVICE DEFAULT>',
:debug => '<SERVICE DEFAULT>',
)
end
end
@ -70,6 +72,7 @@ describe 'keystone::logging' do
it 'configures keystone logging settings with non-default values' do
is_expected.to contain_oslo__log('keystone_config').with(
:use_syslog => true,
:use_journal => true,
:use_stderr => false,
:syslog_log_facility => 'LOG_FOO',
:log_dir => '/var/log',