openstack
/
puppet-keystone
Code Issues Proposed changes

Do not test detail of oslo::cors 

This change makes unit test cases for keystone::cors, so that these
tests do not test behavir of oslo::cors but how oslo::cors resource
type is called by keystone::cors.

Change-Id: I3cc08b121435168ecfcf127bd87d570f394fb009
This commit is contained in:
Takashi Kajinami 2021-07-01 17:59:59 +09:00
parent fea3ef551c
commit cb6f19237f
1 changed files with 20 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
spec/classes/keystone_cors_spec.rb
View File

@ -1,14 +1,17 @@
require 'spec_helper' require 'spec_helper'
describe 'keystone::cors' do describe 'keystone::cors' do
shared_examples 'keystone::cors' do
shared_examples_for 'keystone::cors' do
it 'configure cors default params' do it 'configure cors default params' do
is_expected.to contain_keystone_config('cors/allowed_origin').with_value('<SERVICE DEFAULT>') is_expected.to contain_oslo__cors('keystone_config').with(
is_expected.to contain_keystone_config('cors/allow_credentials').with_value('<SERVICE DEFAULT>') :allowed_origin => '<SERVICE DEFAULT>',
is_expected.to contain_keystone_config('cors/expose_headers').with_value('<SERVICE DEFAULT>') :allow_credentials => '<SERVICE DEFAULT>',
is_expected.to contain_keystone_config('cors/max_age').with_value('<SERVICE DEFAULT>') :expose_headers => '<SERVICE DEFAULT>',
is_expected.to contain_keystone_config('cors/allow_methods').with_value('<SERVICE DEFAULT>') :max_age => '<SERVICE DEFAULT>',
is_expected.to contain_keystone_config('cors/allow_headers').with_value('<SERVICE DEFAULT>') :allow_methods => '<SERVICE DEFAULT>',
:allow_headers => '<SERVICE DEFAULT>',
)
end end
context 'with specific parameters' do context 'with specific parameters' do
@ -23,18 +26,20 @@ describe 'keystone::cors' do
end end
it 'configure cors params' do it 'configure cors params' do
is_expected.to contain_keystone_config('cors/allowed_origin').with_value('*') is_expected.to contain_oslo__cors('keystone_config').with(
is_expected.to contain_keystone_config('cors/allow_credentials').with_value(true) :allowed_origin => '*',
is_expected.to contain_keystone_config('cors/expose_headers').with_value('Content-Language,Expires') :allow_credentials => true,
is_expected.to contain_keystone_config('cors/max_age').with_value(3600) :expose_headers => 'Content-Language,Expires',
is_expected.to contain_keystone_config('cors/allow_methods').with_value('GET,POST,PUT,DELETE,OPTIONS') :max_age => 3600,
is_expected.to contain_keystone_config('cors/allow_headers').with_value('Content-Type,Cache-Control') :allow_methods => 'GET,POST,PUT,DELETE,OPTIONS',
:allow_headers => 'Content-Type,Cache-Control',
)
end end
end end
end end
on_supported_os({ on_supported_os({
:supported_os => OSDefaults.get_supported_os :supported_os => OSDefaults.get_supported_os
}).each do |os,facts| }).each do |os,facts|
context "on #{os}" do context "on #{os}" do
let (:facts) do let (:facts) do
@ -44,4 +49,5 @@ describe 'keystone::cors' do
it_behaves_like 'keystone::cors' it_behaves_like 'keystone::cors'
end end
end end
end end