From ae556eec8fc44146c8b9492da1e10540c516f19e Mon Sep 17 00:00:00 2001 From: Denis Egorenko Date: Wed, 13 Jan 2016 20:00:10 +0300 Subject: [PATCH] Refactor of domain_name_from_id Small refactoring of domain_name_from_id for keystone provider. Change-Id: I5f63fb2705a59ac233c0dc1c2e323322751ebb87 --- lib/puppet/provider/keystone.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/puppet/provider/keystone.rb b/lib/puppet/provider/keystone.rb index 90e0a8542..b6978dc4e 100644 --- a/lib/puppet/provider/keystone.rb +++ b/lib/puppet/provider/keystone.rb @@ -105,10 +105,8 @@ class Puppet::Provider::Keystone < Puppet::Provider::Openstack end unless @domain_hash.include?(id) name = request('domain', 'show', id)[:name] - @domain_hash[id] = name if name - end - unless @domain_hash.include?(id) - err("Could not find domain with id [#{id}]") + err("Could not find domain with id [#{id}]") unless name + @domain_hash[id] = name end @domain_hash[id] end