... and migrate it to openstacklib so that all logics about database
configuration are implemented in one common place.
Depends-on: https://review.opendev.org/#/c/728595/
Change-Id: Ie564c3ae6023a36f317b963872059509754970e5
This converts some more testing to rspec-puppet-facts
so there is only these three missing now until done:
* keystone_init_spec.rb
* keystone_federation_identity_provider_spec.rb
* keystone_ldap_spec.rb
Also does cleanup of some formatting for documentation
and testing specs.
Change-Id: Ifd74aa8cedf630d98f9e12ab276300409a68eecd
The puppet-keystone project consolidated keystone applications:
ace7aeb3b7 (diff-e5968f40345cf5d3be0539fbba87f787)
This effectively reduces the number of available workers to process
keystone requests since only half the processes are deployed now that
the applications are consolidated [0]. As a result, we see a performance
regression [1] when interacting with keystone.
For example, in earlier versions, an 8 core machine would spawn four
processes to serve the keystone-main application. Another four processes
would be spawned to serve the keystone-admin application. Now, we only
have 4 processes total to serve the entire keystone application. Due to
the difference in the number of workers deployed by default, users will
experience reduced performance out-of-the-box.
This patch not only brings performance back to the previous levels, it
is also safe to implement as we are not changing the number of workers
when compared to previous releases and only bringing parity.
[0] https://github.com/openstack/puppet-openstacklib/blob/master/lib/facter/os_workers.rb#L33
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1789495
Co-Authored-By: Takashi Kajinami <tkajinam@redhat.com>
Depends-on: https://review.opendev.org/#/c/705041/
Change-Id: Icf9acaa106af705fa249a2ef2abca9f9a91fba59
This patch changes the default worker count from ::processorcount to the
new ::os_workers fact. ::os_workers is based on the number of processors
(currently cpu/4) but is capped at a maximum of 8 worker processors.
This is a much more reasonable default in general and prevents excessive
resource consumption on systems with a large number of CPUs.
Change-Id: I09076c05ffd42219e8662d3393b1732400d297dc
Switch to $::os_service_default all params in logging and db.
Changes: logging.pp, db.pp and tests.
Related-bug: #1515273
Change-Id: Ib84dceafb032747adc1d8b6e56bd01e89aa802cb
This patch aim to update our specs test in order to work with the
rspec-puppet release 2.0.0, in the mean time, we update rspec syntax in
order to be prepared for rspec 3.x move.
In details:
* Use shared_examples "a Puppet::Error" for puppet::error tests
* Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
* Fix spec tests for rspec-puppet 2.0.0
* Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
* Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper)
* Standardize gemfile (add json, webmock)
Change-Id: I35a39d4f3919d56c9448f0a0602cfe284ebc2e9c
Card: https://trello.com/c/eHXc1Ryd/4-investigate-the-necessary-change-to-be-rspec-puppet-2-0-0-compliant
Let migrate to the new openstacklib::db::postgresql helper for
postgresql backend. This commit also unpin postgresql fixture
(openstacklib support now the latest version of postgre module).
Change-Id: If748f8ff57d8aece1b4050bc4b841495088b2972
Implements: blueprint commmon-openstack-database-resource
The current default db username for keystone is
keystone_admin. This is inconsistent with the default
db username for every other service which use the
same name as the name of the service.
The documented installation instruction for keystone
also use keystone as the database user.
This commit updates the default to use keystone instead of
keyston_admin.
Change-Id: I1cfaf3fbbc691ff9dbef415b69492f9f965dc113
Adds missing tests on the keystone::db::postgresql class. Also,
removes some unsupported options from the class.
Change-Id: Ifab6d06dcd388df07cc9cc06bb8e938d3af90c62
