openstack/puppet-magnum
Code Issues Proposed changes

Add log_file parameter

Browse Source 
Change-Id: I3ffd8bdddfb34b1693cc8eab28df908e39598244
Closes-Bug: #1819417
This commit is contained in:
ZhongShengping 2019-03-12 10:37:38 +08:00
parent 6734a007f6
commit 284f642866
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/logging.pp
View File

@ -33,6 +33,10 @@
# If set to boolean false, it will not log to any directory.
# Defaults to '/var/log/magnum'.
#
# [*log_file*]
# (Optional) File where logs should be stored.
# Defaults to $::os_service_default
#
# [*logging_context_format_string*]
# (Optional) Format string to use for log messages with context.
# Defaults to $::os_service_default
@ -104,6 +108,7 @@ class magnum::logging(
$use_stderr = $::os_service_default,
$log_facility = $::os_service_default,
$log_dir = '/var/log/magnum',
$log_file = $::os_service_default,
$debug = $::os_service_default,
$logging_context_format_string = $::os_service_default,
$logging_default_format_string = $::os_service_default,
@ -127,6 +132,7 @@ class magnum::logging(
use_journal => $use_journal,
use_stderr => $use_stderr,
log_dir => $log_dir,
log_file => $log_file,
syslog_log_facility => $log_facility,
logging_context_format_string => $logging_context_format_string,
logging_default_format_string => $logging_default_format_string,

4
releasenotes/notes/add-log_file-for-logging-ac7fd2e8608813c9.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
Add the log_file option for logging.

3
spec/classes/magnum_logging_spec.rb
View File

@ -29,6 +29,7 @@ describe 'magnum::logging' do
:use_stderr => false,
:log_facility => 'LOG_FOO',
:log_dir => '/var/log',
:log_file => '/var/log/magnum/magnum.log',
:debug => true,
}
end
@ -63,6 +64,7 @@ describe 'magnum::logging' do
:use_journal => '<SERVICE DEFAULT>',
:use_stderr => '<SERVICE DEFAULT>',
:log_dir => '/var/log/magnum',
:log_file => '<SERVICE DEFAULT>',
:debug => '<SERVICE DEFAULT>',
)
end
@ -77,6 +79,7 @@ describe 'magnum::logging' do
:use_stderr => false,
:syslog_log_facility => 'LOG_FOO',
:log_dir => '/var/log',
:log_file => '/var/log/magnum/magnum.log',
:debug => true,
)
end