openstack/puppet-magnum
Code Issues Proposed changes

Deprecate support for [oslo_messaging_rabbit] heartbeat_in_pthread

Browse Source 
... because the option has been deprecated.

Depends-on: https://review.opendev.org/925778
Change-Id: I41835fa8b4713eb2a6d9b492807b167c9f9684c1
This commit is contained in:
Takashi Kajinami 2025-02-18 10:53:52 +09:00
parent 1963b9905a
commit 29b24f0e17
2 changed files with 19 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
manifests/init.pp
View File

@ -63,16 +63,6 @@
# every 30 seconds.
# Defaults to $facts['os_service_default']
#
# [*rabbit_heartbeat_in_pthread*]
# (Optional) EXPERIMENTAL: Run the health check heartbeat thread
# through a native python thread. By default if this
# option isn't provided the health check heartbeat will
# inherit the execution model from the parent process. By
# example if the parent process have monkey patched the
# stdlib by using eventlet/greenlet then the heartbeat
# will be run through a green thread.
# Defaults to $facts['os_service_default']
#
# [*rabbit_qos_prefetch_count*]
# (Optional) Specifies the number of messages to prefetch.
# Defaults to $facts['os_service_default']
@ -152,6 +142,18 @@
# in the magnum config.
# Defaults to false.
#
# DEPRECATED PARAMETERS
#
# [*rabbit_heartbeat_in_pthread*]
# (Optional) EXPERIMENTAL: Run the health check heartbeat thread
# through a native python thread. By default if this
# option isn't provided the health check heartbeat will
# inherit the execution model from the parent process. By
# example if the parent process have monkey patched the
# stdlib by using eventlet/greenlet then the heartbeat
# will be run through a green thread.
# Defaults to undef
#
class magnum(
$package_ensure = 'present',
$notification_transport_url = $facts['os_service_default'],
@ -164,7 +166,6 @@ class magnum(
$rabbit_ha_queues = $facts['os_service_default'],
$rabbit_heartbeat_timeout_threshold = $facts['os_service_default'],
$rabbit_heartbeat_rate = $facts['os_service_default'],
$rabbit_heartbeat_in_pthread = $facts['os_service_default'],
$rabbit_qos_prefetch_count = $facts['os_service_default'],
$rabbit_quorum_queue = $facts['os_service_default'],
$rabbit_transient_quorum_queue = $facts['os_service_default'],
@ -182,6 +183,8 @@ class magnum(
$kombu_compression = $facts['os_service_default'],
$amqp_durable_queues = $facts['os_service_default'],
Boolean $purge_config = false,
# DEPRECATED PARAMETERS
$rabbit_heartbeat_in_pthread = undef,
) {
include magnum::deps

5
releasenotes/notes/deprecate-rabbit_heartbeat_in_pthread-f4f13d0b68913285.yaml Normal file
View File

@ -0,0 +1,5 @@
---
deprecations:
- |
The ``magnum::rabbit_heartbeat_in_pthread`` parameter has been deprecated
and will be removed in the future release.