openstack/puppet-magnum
Code Issues Proposed changes

Do not test detail of keystone::resource::service_identity

Browse Source 
... but test interfaces of that resource type. This helps us avoid
direct breakage caused by any change in puppet-keystone.

Change-Id: If28846223a793c5edc1e7fe37926360397316715
This commit is contained in:
Takashi Kajinami 2021-09-29 09:22:20 +09:00
parent 57504e2c85
commit de33d0334b
1 changed files with 52 additions and 104 deletions

152
spec/classes/magnum_keystone_auth_spec.rb

@ -1,120 +1,68 @@
#
# Unit tests for magnum::keystone::auth
#
require 'spec_helper' require 'spec_helper'
describe 'magnum::keystone::auth' do describe 'magnum::keystone::auth' do
shared_examples 'magnum::keystone::auth' do shared_examples_for 'magnum::keystone::auth' do
context 'with default class parameters' do context 'with default class parameters' do
let :params do let :params do
{ { :password => 'magnum_password' }
:password => 'magnum_password',
:tenant => 'foobar'
}
end end
it { should contain_keystone_user('magnum').with( it { is_expected.to contain_keystone__resource__service_identity('magnum').with(
:ensure => 'present', :configure_user => true,
:password => 'magnum_password', :configure_user_role => true,
)} :configure_endpoint => true,
:service_name => 'magnum',
it { should contain_keystone_user_role('magnum@foobar').with( :service_type => 'container-infra',
:ensure => 'present', :service_description => 'magnum Container Service',
:roles => ['admin'] :region => 'RegionOne',
)}
it { should contain_keystone_service('magnum::container-infra').with(
:ensure => 'present',
:description => 'magnum Container Service'
)}
it { should contain_keystone_endpoint('RegionOne/magnum::container-infra').with(
:ensure => 'present',
:public_url => 'http://127.0.0.1:9511/v1',
:admin_url => 'http://127.0.0.1:9511/v1',
:internal_url => 'http://127.0.0.1:9511/v1',
)}
end
context 'when overriding URL paramaters' do
let :params do
{
:password => 'magnum_password',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81',
}
end
it { should contain_keystone_endpoint('RegionOne/magnum::container-infra').with(
:ensure => 'present',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81',
)}
end
context 'when overriding auth name' do
let :params do
{
:password => 'foo',
:auth_name => 'magnumy'
}
end
it { should contain_keystone_user('magnumy') }
it { should contain_keystone_user_role('magnumy@services') }
it { should contain_keystone_service('magnumy::container-infra') }
it { should contain_keystone_endpoint('RegionOne/magnumy::container-infra') }
end
context 'when overriding service name' do
let :params do
{
:service_name => 'magnum_service',
:auth_name => 'magnum', :auth_name => 'magnum',
:password => 'magnum_password'
}
end
it { should contain_keystone_user('magnum') }
it { should contain_keystone_user_role('magnum@services') }
it { should contain_keystone_service('magnum_service::container-infra') }
it { should contain_keystone_endpoint('RegionOne/magnum_service::container-infra') }
end
context 'when disabling user configuration' do
let :params do
{
:password => 'magnum_password', :password => 'magnum_password',
:configure_user => false :email => 'magnum@localhost',
} :tenant => 'services',
:public_url => 'http://127.0.0.1:9511/v1',
:internal_url => 'http://127.0.0.1:9511/v1',
:admin_url => 'http://127.0.0.1:9511/v1',
) }
end end
it { should_not contain_keystone_user('magnum') } context 'when overriding parameters' do
it { should contain_keystone_user_role('magnum@services') }
it { should contain_keystone_service('magnum::container-infra').with(
:ensure => 'present',
:type => 'container-infra',
:description => 'magnum Container Service'
)}
end
context 'when disabling user and user role configuration' do
let :params do let :params do
{ { :password => 'magnum_password',
:password => 'magnum_password', :auth_name => 'alt_magnum',
:email => 'alt_magnum@alt_localhost',
:tenant => 'alt_service',
:configure_endpoint => false,
:configure_user => false, :configure_user => false,
:configure_user_role => false :configure_user_role => false,
} :service_description => 'Alternative magnum Container Service',
:service_name => 'alt_service',
:service_type => 'alt_container-infra',
:region => 'RegionTwo',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81' }
end end
it { should_not contain_keystone_user('magnum') } it { is_expected.to contain_keystone__resource__service_identity('magnum').with(
it { should_not contain_keystone_user_role('magnum@services') } :configure_user => false,
:configure_user_role => false,
it { should contain_keystone_service('magnum::container-infra').with( :configure_endpoint => false,
:ensure => 'present', :service_name => 'alt_service',
:type => 'container-infra', :service_type => 'alt_container-infra',
:description => 'magnum Container Service' :service_description => 'Alternative magnum Container Service',
)} :region => 'RegionTwo',
:auth_name => 'alt_magnum',
:password => 'magnum_password',
:email => 'alt_magnum@alt_localhost',
:tenant => 'alt_service',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81',
) }
end end
end end