openstack
/
puppet-manila
Code Issues Proposed changes

Expose executor_thread_pool_size 

This option has been supported by puppet-oslo but has not been
configurable.

Change-Id: I260f33942bcd08396c099e52ba970ad8ad5da9d8
This commit is contained in:
Takashi Kajinami 2023-03-13 11:45:03 +09:00
parent 1ef4ab6ebd
commit bc11b59fa4
3 changed files with 22 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
manifests/init.pp
View File

@ -20,6 +20,10 @@
# (Optional) The default exchange under which topics are scope.
# Defaults to $facts['os_service_default']
#
# [*executor_thread_pool_size*]
# (Optional) Size of executor thread pool when executor is threading or eventlet.
# Defaults to $facts['os_service_default'].
#
# [*package_ensure*]
# (Optional) Ensure state for package.
# Defaults to 'present'
@ -204,6 +208,7 @@ class manila (
$default_transport_url = $facts['os_service_default'],
$rpc_response_timeout = $facts['os_service_default'],
$control_exchange = $facts['os_service_default'],
$executor_thread_pool_size = $facts['os_service_default'],
$notification_transport_url = $facts['os_service_default'],
$notification_driver = 'messaging',
$notification_topics = $facts['os_service_default'],
@ -304,9 +309,10 @@ class manila (
}
oslo::messaging::default { 'manila_config':
transport_url => $default_transport_url,
rpc_response_timeout => $rpc_response_timeout,
control_exchange => $control_exchange,
executor_thread_pool_size => $executor_thread_pool_size,
transport_url => $default_transport_url,
rpc_response_timeout => $rpc_response_timeout,
control_exchange => $control_exchange,
}
oslo::messaging::notifications { 'manila_config':

4
releasenotes/notes/executor_thread_pool_size-5cbf844897b55c15.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
The new ``manila::executor_thread_pool_size`` parameter has been added.

15
spec/classes/manila_init_spec.rb
View File

@ -22,9 +22,10 @@ describe 'manila' do
it 'should contain default config' do
is_expected.to contain_oslo__messaging__default('manila_config').with(
:transport_url => '<SERVICE DEFAULT>',
:rpc_response_timeout => '<SERVICE DEFAULT>',
:control_exchange => '<SERVICE DEFAULT>',
:executor_thread_pool_size => '<SERVICE DEFAULT>',
:transport_url => '<SERVICE DEFAULT>',
:rpc_response_timeout => '<SERVICE DEFAULT>',
:control_exchange => '<SERVICE DEFAULT>',
)
is_expected.to contain_oslo__messaging__notifications('manila_config').with(
:transport_url => '<SERVICE DEFAULT>',
@ -186,13 +187,15 @@ describe 'manila' do
:rpc_response_timeout => '120',
:control_exchange => 'manila',
:notification_transport_url => 'rabbit://rabbit_user:password@localhost:5673',
:executor_thread_pool_size => 64,
}
end
it { is_expected.to contain_oslo__messaging__default('manila_config').with(
:transport_url => 'rabbit://rabbit_user:password@localhost:5673',
:rpc_response_timeout => '120',
:control_exchange => 'manila',
:executor_thread_pool_size => 64,
:transport_url => 'rabbit://rabbit_user:password@localhost:5673',
:rpc_response_timeout => '120',
:control_exchange => 'manila',
) }
it { is_expected.to contain_oslo__messaging__notifications('manila_config').with(