Do not define service resource when service management is disabled

Change-Id: Ib0dff603408fa8bf1639ef7708484b6206104840

manifests/api.pp

@@ -101,42 +101,41 @@ class manila::api (
     include manila::db::sync
   }
 
-  if $enabled {
-    if $manage_service {
+  if $manage_service {
+    if $enabled {
       $ensure = 'running'
-    }
-  } else {
-    if $manage_service {
+    } else {
       $ensure = 'stopped'
     }
-  }
 
-  if $service_name == $::manila::params::api_service {
-    service { 'manila-api':
-      ensure    => $ensure,
-      name      => $::manila::params::api_service,
-      enable    => $enabled,
-      hasstatus => true,
-      tag       => 'manila-service',
-    }
+    if $service_name == $::manila::params::api_service {
+      service { 'manila-api':
+        ensure    => $ensure,
+        name      => $::manila::params::api_service,
+        enable    => $enabled,
+        hasstatus => true,
+        tag       => 'manila-service',
+      }
 
-  } elsif $service_name == 'httpd' {
-    # We need to make sure manila-api/eventlet is stopped before trying to
-    # start apache
-    service { 'manila-api':
-      ensure => 'stopped',
-      name   => $::manila::params::api_service,
-      enable => false,
-      tag    => ['manila-service'],
-    }
-    Service <| title == 'httpd' |> { tag +> 'manila-service' }
+    } elsif $service_name == 'httpd' {
+      # We need to make sure manila-api/eventlet is stopped before trying to
+      # start apache
+      service { 'manila-api':
+        ensure => 'stopped',
+        name   => $::manila::params::api_service,
+        enable => false,
+        tag    => ['manila-service'],
+      }
+      Service <| title == 'httpd' |> { tag +> 'manila-service' }
 
-    Service['manila-api'] -> Service[$service_name]
-  } else {
-    fail("Invalid service_name. Either use manila-api/openstack-manila-api \
+      Service['manila-api'] -> Service[$service_name]
+    } else {
+      fail("Invalid service_name. Either use manila-api/openstack-manila-api \
 for running as a standalone service, or httpd for being run by a httpd \
 server.")
+    }
   }
+
   manila_config {
     'DEFAULT/osapi_share_listen':      value => $bind_host;
     'DEFAULT/enabled_share_protocols': value => join(any2array($enabled_share_protocols), ',');

manifests/scheduler.pp

@@ -50,13 +50,13 @@ class manila::scheduler (
     } else {
       $ensure = 'stopped'
     }
-  }
 
-  service { 'manila-scheduler':
-    ensure    => $ensure,
-    name      => $::manila::params::scheduler_service,
-    enable    => $enabled,
-    hasstatus => true,
-    tag       => 'manila-service',
+    service { 'manila-scheduler':
+      ensure    => $ensure,
+      name      => $::manila::params::scheduler_service,
+      enable    => $enabled,
+      hasstatus => true,
+      tag       => 'manila-service',
+    }
   }
 }

manifests/share.pp

@@ -38,14 +38,14 @@ class manila::share (
     } else {
       $ensure = 'stopped'
     }
-  }
 
-  service { 'manila-share':
-    ensure    => $ensure,
-    name      => $::manila::params::share_service,
-    enable    => $enabled,
-    hasstatus => true,
-    require   => Package['manila'],
-    tag       => 'manila-service',
+    service { 'manila-share':
+      ensure    => $ensure,
+      name      => $::manila::params::share_service,
+      enable    => $enabled,
+      hasstatus => true,
+      require   => Package['manila'],
+      tag       => 'manila-service',
+    }
   }
 }

spec/classes/manila_api_spec.rb

@@ -131,8 +131,8 @@ describe 'manila::api' do
         req_params.merge({'manage_service' => false})
       end
       it { is_expected.to contain_class('manila::policy') }
-      it 'should not change the state of the service' do
-        is_expected.to contain_service('manila-api').without_ensure
+      it 'should not configure the service' do
+        is_expected.to_not contain_service('manila-api')
       end
     end
 

spec/classes/manila_scheduler_spec.rb

@@ -40,8 +40,8 @@ describe 'manila::scheduler' do
         { 'manage_service' => false
         }
       end
-      it 'should not change the state of the service' do
-        is_expected.to contain_service('manila-scheduler').without_ensure
+      it 'should not configure the service' do
+        is_expected.to_not contain_service('manila-scheduler')
       end
     end
   end

spec/classes/manila_share_spec.rb

@@ -21,8 +21,8 @@ describe 'manila::share' do
       let :params do
         { 'manage_service' => false }
       end
-      it 'should not change the state of the service' do
-        is_expected.to contain_service('manila-share').without_ensure
+      it 'should not configure the service' do
+        is_expected.to_not contain_service('manila-share')
       end
     end
   end