openstack/puppet-mistral
Code Issues Proposed changes

Do not test detail of keystone::resource::service_identity

Browse Source 
... but test interfaces of that resource type. This helps us avoid
direct breakage caused by any change in puppet-keystone.

Change-Id: I8a5ce23c55ac52f155a4cfec322eb3831df7494f
This commit is contained in:
Takashi Kajinami 2021-09-27 13:09:10 +09:00
parent 3a599ed480
commit 2177caed38
1 changed files with 52 additions and 70 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

122
spec/classes/mistral_keystone_auth_spec.rb
View File

@ -1,86 +1,68 @@
#
# Unit tests for mistral::keystone::auth
#
require 'spec_helper'
describe 'mistral::keystone::auth' do
shared_examples 'mistral::keystone::auth' do
shared_examples_for 'mistral::keystone::auth' do
context 'with default class parameters' do
let :params do
{
:password => 'mistral_password',
:tenant => 'services'
}
{ :password => 'mistral_password' }
end
it { should contain_keystone_user('mistral').with(
:ensure => 'present',
:password => 'mistral_password',
)}
it { should contain_keystone_user_role('mistral@services').with(
:ensure => 'present',
:roles => ['admin']
)}
it { should contain_keystone_service('mistral::workflowv2').with(
:ensure => 'present',
:description => 'OpenStack Workflow Service'
)}
it { should contain_keystone_endpoint('RegionOne/mistral::workflowv2').with(
:ensure => 'present',
:public_url => "http://127.0.0.1:8989/v2",
:admin_url => "http://127.0.0.1:8989/v2",
:internal_url => "http://127.0.0.1:8989/v2"
)}
it { is_expected.to contain_keystone__resource__service_identity('mistral').with(
:configure_user => true,
:configure_user_role => true,
:configure_endpoint => true,
:service_name => 'mistral',
:service_type => 'workflowv2',
:service_description => 'OpenStack Workflow Service',
:region => 'RegionOne',
:auth_name => 'mistral',
:password => 'mistral_password',
:email => 'mistral@localhost',
:tenant => 'services',
:public_url => 'http://127.0.0.1:8989/v2',
:internal_url => 'http://127.0.0.1:8989/v2',
:admin_url => 'http://127.0.0.1:8989/v2',
) }
end
context 'when overriding auth and service name' do
context 'when overriding parameters' do
let :params do
{
:service_name => 'mistraly',
:auth_name => 'mistraly',
:password => 'mistral_password'
}
end
it { should contain_keystone_user('mistraly') }
it { should contain_keystone_user_role('mistraly@services') }
it { should contain_keystone_service('mistraly::workflowv2') }
it { should contain_keystone_endpoint('RegionOne/mistraly::workflowv2') }
end
context 'when disabling user configuration' do
let :params do
{
:password => 'mistral_password',
:configure_user => false
}
end
it { should_not contain_keystone_user('mistral') }
it { should contain_keystone_user_role('mistral@services') }
it { should contain_keystone_service('mistral::workflowv2').with(
:ensure => 'present',
:description => 'OpenStack Workflow Service'
)}
end
context 'when disabling user and user role configuration' do
let :params do
{
:password => 'mistral_password',
{ :password => 'mistral_password',
:auth_name => 'alt_mistral',
:email => 'alt_mistral@alt_localhost',
:tenant => 'alt_service',
:configure_endpoint => false,
:configure_user => false,
:configure_user_role => false
}
:configure_user_role => false,
:service_description => 'Alternative OpenStack Workflow Service',
:service_name => 'alt_service',
:service_type => 'alt_workflowv2',
:region => 'RegionTwo',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81' }
end
it { should_not contain_keystone_user('mistral') }
it { should_not contain_keystone_user_role('mistral@services') }
it { should contain_keystone_service('mistral::workflowv2').with(
:ensure => 'present',
:description => 'OpenStack Workflow Service'
)}
it { is_expected.to contain_keystone__resource__service_identity('mistral').with(
:configure_user => false,
:configure_user_role => false,
:configure_endpoint => false,
:service_name => 'alt_service',
:service_type => 'alt_workflowv2',
:service_description => 'Alternative OpenStack Workflow Service',
:region => 'RegionTwo',
:auth_name => 'alt_mistral',
:password => 'mistral_password',
:email => 'alt_mistral@alt_localhost',
:tenant => 'alt_service',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81',
) }
end
end