Add service role by default

This is the role created to be used by service users. At this moment
several services/functionalities still need the admin role so is kept.

Change-Id: Ieaede1d2f8a7d6ee8dbf128405a792be8763abda
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>

manifests/keystone/auth.pp

@@ -21,7 +21,7 @@
 #
 # [*roles*]
 #   (Optional) List of roles assigned to neutron user.
-#   Defaults to ['admin']
+#   Defaults to ['admin', 'service']
 #
 # [*system_scope*]
 #   (Optional) Scope for system operations.
@@ -86,7 +86,7 @@ class mistral::keystone::auth (
   Keystone::EndpointUrl $internal_url     = 'http://127.0.0.1:8989/v2',
   String[1] $region                       = 'RegionOne',
   String[1] $tenant                       = 'services',
-  Array[String[1]] $roles                 = ['admin'],
+  Array[String[1]] $roles                 = ['admin', 'service'],
   String[1] $system_scope                 = 'all',
   Array[String[1]] $system_roles          = [],
   Boolean $configure_endpoint             = true,

releasenotes/notes/service-role-a5c799d0aae64c87.yaml

@@ -0,0 +1,5 @@
+---
+features:
+  - |
+    The ``mistral::keystone::auth`` class now adds the ``service`` role by
+    default. Set the ``roles`` parameter not to add the role.

spec/classes/mistral_keystone_auth_spec.rb

@@ -24,7 +24,7 @@ describe 'mistral::keystone::auth' do
         :password            => 'mistral_password',
         :email               => 'mistral@localhost',
         :tenant              => 'services',
-        :roles               => ['admin'],
+        :roles               => ['admin', 'service'],
         :system_scope        => 'all',
         :system_roles        => [],
         :public_url          => 'http://127.0.0.1:8989/v2',
@@ -39,7 +39,7 @@ describe 'mistral::keystone::auth' do
           :auth_name           => 'alt_mistral',
           :email               => 'alt_mistral@alt_localhost',
           :tenant              => 'alt_service',
-          :roles               => ['admin', 'service'],
+          :roles               => ['admin'],
           :system_scope        => 'alt_all',
           :system_roles        => ['admin', 'member', 'reader'],
           :configure_endpoint  => false,
@@ -68,7 +68,7 @@ describe 'mistral::keystone::auth' do
         :password            => 'mistral_password',
         :email               => 'alt_mistral@alt_localhost',
         :tenant              => 'alt_service',
-        :roles               => ['admin', 'service'],
+        :roles               => ['admin'],
         :system_scope        => 'alt_all',
         :system_roles        => ['admin', 'member', 'reader'],
         :public_url          => 'https://10.10.10.10:80',