openstack/puppet-mistral
Code Issues Proposed changes

Use new openstackclient tag

Browse Source 
This looses dependency using the new openstackclient tag, which
requires only packages actually related to openstack CLI.

Also, mistralclient is not required by mistral itself so the service
package tag can be removed.

Depends-on: https://review.opendev.org/899594
Change-Id: I9752cc53f02fbe78afc286aadf91c6aa55d4116b
This commit is contained in:
Takashi Kajinami 2023-11-20 00:41:55 +09:00
parent 29899b8bda
commit 8cbc3c6e78
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/client.pp
View File

@ -17,7 +17,7 @@ class mistral::client(
package { 'python-mistralclient': package { 'python-mistralclient':
ensure => $package_ensure, ensure => $package_ensure,
name => $::mistral::params::client_package, name => $::mistral::params::client_package,
tag => ['openstack', 'mistral-package'], tag => ['openstack', 'openstackclient'],
} }
include openstacklib::openstackclient include openstacklib::openstackclient

4
manifests/deps.pp
View File

@ -41,8 +41,8 @@ class mistral::deps {
# will have clients available to create resources. This tag handles the # will have clients available to create resources. This tag handles the
# openstackclient but indirectly since the client is not available in # openstackclient but indirectly since the client is not available in
# all catalogs that don't need the client class (like many spec tests) # all catalogs that don't need the client class (like many spec tests)
Package<| tag == 'openstack'|> Package<| tag == 'openstackclient'|>
~> Anchor['mistral::service::end'] -> Anchor['mistral::service::end']
# Installation or config changes will always restart services. # Installation or config changes will always restart services.
Anchor['mistral::install::end'] ~> Anchor['mistral::service::begin'] Anchor['mistral::install::end'] ~> Anchor['mistral::service::begin']

2
spec/classes/mistral_client_spec.rb
View File

@ -11,7 +11,7 @@ describe 'mistral::client' do
is_expected.to contain_package('python-mistralclient').with( is_expected.to contain_package('python-mistralclient').with(
:ensure => 'present', :ensure => 'present',
:name => platform_params[:client_package], :name => platform_params[:client_package],
:tag => ['openstack', 'mistral-package'] :tag => ['openstack', 'openstackclient']
) )
end end