Update patch set 1

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Reviewer: Gerrit User 9816 <9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 25241 \u003c25241@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Takashi Kajinami replied on the change"}

2bbc8e91ba7bc630b226c78ae6de3c8b3400489b

@@ -0,0 +1,67 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "45878191_3e67dadb",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 1
+      },
+      "lineNbr": 7,
+      "author": {
+        "id": 9816
+      },
+      "writtenOn": "2021-10-19T11:35:35Z",
+      "side": 1,
+      "message": "The general guidance is to keep the first line shorter than 50 characters. \n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure",
+      "range": {
+        "startLine": 7,
+        "startChar": 0,
+        "endLine": 7,
+        "endChar": 79
+      },
+      "revId": "2bbc8e91ba7bc630b226c78ae6de3c8b3400489b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "88fcc07c_07ef1021",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 1
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 9816
+      },
+      "writtenOn": "2021-10-19T11:35:35Z",
+      "side": 1,
+      "message": "Thank you for proposing the patch. Please find the comments inline.\n\nAlso, could you please add a release note file to explain the change in parameter interface ?",
+      "revId": "2bbc8e91ba7bc630b226c78ae6de3c8b3400489b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "463e5d75_8602b450",
+        "filename": "manifests/plugins/ml2/mellanox/mlnx_sdn_assist.pp",
+        "patchSetId": 1
+      },
+      "lineNbr": 45,
+      "author": {
+        "id": 9816
+      },
+      "writtenOn": "2021-10-19T11:35:35Z",
+      "side": 1,
+      "message": "Please do not remove the old parameter because it is breaking the interface. Any parameters should be deprecated first and kept for one cycle.\n\nAlso, I\u0027d agree that adding sdn_token would be useful but I don\u0027t really see much benefit of removing username and password and wondering whether it makes sense to keep basic auth and just ad the token parameter. Is there any specific concern with allowing usage of username/password ? (I\u0027d agree with dropping basic auth if that is deprecated in mellanox plugin)",
+      "range": {
+        "startLine": 45,
+        "startChar": 2,
+        "endLine": 45,
+        "endChar": 37
+      },
+      "revId": "2bbc8e91ba7bc630b226c78ae6de3c8b3400489b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}