diff --git a/manifests/init.pp b/manifests/init.pp index 3ba4173ca..d5bf88baf 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -246,10 +246,6 @@ # (Optional) Password for decrypting ssl_key_file (if encrypted) # Defaults to $::os_service_default. # -# [*amqp_allow_insecure_clients*] -# (Optional) Accept clients using either SSL or plain TCP -# Defaults to $::os_service_default. -# # [*amqp_sasl_mechanisms*] # (Optional) Space separated list of acceptable SASL mechanisms # Defaults to $::os_service_default. @@ -325,6 +321,12 @@ # (optional) Allow plugins that support it to create VLAN transparent networks # Defaults to $::os_service_default # +# DEPRECATED PARAMETERS +# +# [*amqp_allow_insecure_clients*] +# (Optional) Accept clients using either SSL or plain TCP +# Defaults to undef. +# class neutron ( $enabled = true, $package_ensure = 'present', @@ -375,7 +377,6 @@ class neutron ( $amqp_ssl_cert_file = $::os_service_default, $amqp_ssl_key_file = $::os_service_default, $amqp_ssl_key_password = $::os_service_default, - $amqp_allow_insecure_clients = $::os_service_default, $amqp_sasl_mechanisms = $::os_service_default, $amqp_sasl_config_dir = $::os_service_default, $amqp_sasl_config_name = $::os_service_default, @@ -393,11 +394,18 @@ class neutron ( $notification_transport_url = $::os_service_default, $max_allowed_address_pair = $::os_service_default, $vlan_transparent = $::os_service_default, + # DEPRECATED PARAMETERS + $amqp_allow_insecure_clients = undef, ) { include neutron::deps include neutron::params + if $amqp_allow_insecure_clients != undef { + warning('The amqp_allow_insecure_clients parameter is deprecated and \ +will be removed in a future release.') + } + if ! is_service_default($use_ssl) and ($use_ssl) { if is_service_default($cert_file) { fail('The cert_file parameter is required when use_ssl is set to true') @@ -497,22 +505,21 @@ class neutron ( } oslo::messaging::amqp { 'neutron_config': - server_request_prefix => $amqp_server_request_prefix, - broadcast_prefix => $amqp_broadcast_prefix, - group_request_prefix => $amqp_group_request_prefix, - container_name => $amqp_container_name, - idle_timeout => $amqp_idle_timeout, - trace => $amqp_trace, - ssl_ca_file => $amqp_ssl_ca_file, - ssl_cert_file => $amqp_ssl_cert_file, - ssl_key_file => $amqp_ssl_key_file, - ssl_key_password => $amqp_ssl_key_password, - allow_insecure_clients => $amqp_allow_insecure_clients, - sasl_mechanisms => $amqp_sasl_mechanisms, - sasl_config_dir => $amqp_sasl_config_dir, - sasl_config_name => $amqp_sasl_config_name, - username => $amqp_username, - password => $amqp_password, + server_request_prefix => $amqp_server_request_prefix, + broadcast_prefix => $amqp_broadcast_prefix, + group_request_prefix => $amqp_group_request_prefix, + container_name => $amqp_container_name, + idle_timeout => $amqp_idle_timeout, + trace => $amqp_trace, + ssl_ca_file => $amqp_ssl_ca_file, + ssl_cert_file => $amqp_ssl_cert_file, + ssl_key_file => $amqp_ssl_key_file, + ssl_key_password => $amqp_ssl_key_password, + sasl_mechanisms => $amqp_sasl_mechanisms, + sasl_config_dir => $amqp_sasl_config_dir, + sasl_config_name => $amqp_sasl_config_name, + username => $amqp_username, + password => $amqp_password, } # SSL Options diff --git a/releasenotes/notes/deprecate_allow_insecure_clients-option-aa02afe6931b7d6b.yaml b/releasenotes/notes/deprecate_allow_insecure_clients-option-aa02afe6931b7d6b.yaml new file mode 100644 index 000000000..72dff7546 --- /dev/null +++ b/releasenotes/notes/deprecate_allow_insecure_clients-option-aa02afe6931b7d6b.yaml @@ -0,0 +1,4 @@ +--- +deprecations: + - allow_insecure_clients option is now deprecated for removal, the + parameter has no effect. diff --git a/spec/classes/neutron_init_spec.rb b/spec/classes/neutron_init_spec.rb index 73d2a2073..9931f8222 100644 --- a/spec/classes/neutron_init_spec.rb +++ b/spec/classes/neutron_init_spec.rb @@ -409,7 +409,6 @@ describe 'neutron' do it { should contain_neutron_config('oslo_messaging_amqp/ssl_cert_file').with_value('') } it { should contain_neutron_config('oslo_messaging_amqp/ssl_key_file').with_value('') } it { should contain_neutron_config('oslo_messaging_amqp/ssl_key_password').with_value('') } - it { should contain_neutron_config('oslo_messaging_amqp/allow_insecure_clients').with_value('') } it { should contain_neutron_config('oslo_messaging_amqp/sasl_mechanisms').with_value('') } it { should contain_neutron_config('oslo_messaging_amqp/sasl_config_dir').with_value('') } it { should contain_neutron_config('oslo_messaging_amqp/sasl_config_name').with_value('') } @@ -437,7 +436,6 @@ describe 'neutron' do it { should contain_neutron_config('oslo_messaging_amqp/ssl_ca_file').with_value('/path/to/ca.cert') } it { should contain_neutron_config('oslo_messaging_amqp/ssl_cert_file').with_value('/path/to/certfile') } it { should contain_neutron_config('oslo_messaging_amqp/ssl_key_file').with_value('/path/to/key') } - it { should contain_neutron_config('oslo_messaging_amqp/allow_insecure_clients').with_value('') } it { should contain_neutron_config('oslo_messaging_amqp/sasl_mechanisms').with_value('') } it { should contain_neutron_config('oslo_messaging_amqp/sasl_config_dir').with_value('') } it { should contain_neutron_config('oslo_messaging_amqp/sasl_config_name').with_value('') }