From b8948287d625b2f6900b0244d2f6db65bcf7ad05 Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <tkajinam@redhat.com>
Date: Fri, 14 Jan 2022 11:19:43 +0900
Subject: [PATCH] Deprecate support for [nova] live_migration_events

Change-Id: Icd130ccd24b61eee38d6a9da17d6cc1d66064927
---
 manifests/server/notifications/nova.pp               | 12 ++++++++++--
 ...-nova-live_migration_events-2663d871c5eb5811.yaml |  5 +++++
 2 files changed, 15 insertions(+), 2 deletions(-)
 create mode 100644 releasenotes/notes/deprecate-nova-live_migration_events-2663d871c5eb5811.yaml

diff --git a/manifests/server/notifications/nova.pp b/manifests/server/notifications/nova.pp
index 03ffa18d3..fd290fced 100644
--- a/manifests/server/notifications/nova.pp
+++ b/manifests/server/notifications/nova.pp
@@ -69,6 +69,8 @@
 #   the keystone catalog.
 #   Defaults to $::os_service_default
 #
+# DEPRECATED PARAMETERS
+#
 # [*live_migration_events*]
 #   (optional) When this option is enabled, during the live migration, the OVS
 #   agent will only send the "vif-plugged-event" when the destination host
@@ -88,11 +90,17 @@ class neutron::server::notifications::nova (
   $auth_url                           = 'http://127.0.0.1:5000',
   $region_name                        = $::os_service_default,
   $endpoint_type                      = $::os_service_default,
-  $live_migration_events              = $::os_service_default,
+  # DEPRECATED PARAMETERS
+  $live_migration_events              = undef,
 ) {
 
   include neutron::deps
 
+  if $live_migration_events != undef {
+    warning('The live_migration_events parameter is deprecated \
+and will be removed in a future release')
+  }
+
   if is_service_default($system_scope) {
     $project_name_real = $project_name
     $project_domain_name_real = $project_domain_name
@@ -115,7 +123,7 @@ class neutron::server::notifications::nova (
   }
 
   neutron_config {
-    'nova/live_migration_events':                 value => $live_migration_events;
+    'nova/live_migration_events':                 value => pick($live_migration_events, $::os_service_default);
     'DEFAULT/notify_nova_on_port_status_changes': value => $notify_nova_on_port_status_changes;
     'DEFAULT/notify_nova_on_port_data_changes':   value => $notify_nova_on_port_data_changes;
   }
diff --git a/releasenotes/notes/deprecate-nova-live_migration_events-2663d871c5eb5811.yaml b/releasenotes/notes/deprecate-nova-live_migration_events-2663d871c5eb5811.yaml
new file mode 100644
index 000000000..1d1389071
--- /dev/null
+++ b/releasenotes/notes/deprecate-nova-live_migration_events-2663d871c5eb5811.yaml
@@ -0,0 +1,5 @@
+---
+deprecations:
+  - |
+    The ``neutron::server::notifications::nova::live_migration_events``
+    parameter has been deprecated and will be removed in a future release.