From eb1178f73c622f1a5970f9f7316f6935be51277d Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <tkajinam@redhat.com>
Date: Mon, 28 Nov 2022 18:51:31 +0900
Subject: [PATCH] Clean up parameter for service validation

... service validation was deprecated during Yoga cycle by [1].
The parameter was left for interface compatibility but has had no
effect since then.

[1] 35659b8d918e8e10e8dbbadf29339d04069bceb3

Change-Id: I40782633478784b599bcba9ca29b525f2b952ece
---
 manifests/server.pp                                  | 12 ------------
 .../remove-service-validation-ea042dda42e67fd4.yaml  |  4 ++++
 2 files changed, 4 insertions(+), 12 deletions(-)
 create mode 100644 releasenotes/notes/remove-service-validation-ea042dda42e67fd4.yaml

diff --git a/manifests/server.pp b/manifests/server.pp
index a29255ce2..8d02def88 100644
--- a/manifests/server.pp
+++ b/manifests/server.pp
@@ -225,12 +225,6 @@
 #   mechanism driver for Neutron.
 #   Defaults to $::os_service_default
 #
-# DEPRECATED PARAMETERS
-#
-# [*validate*]
-#   (Optional) Whether to validate the service is working after any service refreshes
-#   Defaults to undef
-#
 class neutron::server (
   $package_ensure                   = 'present',
   $enabled                          = true,
@@ -269,18 +263,12 @@ class neutron::server (
   $max_request_body_size            = $::os_service_default,
   $ovs_integration_bridge           = $::os_service_default,
   $igmp_snooping_enable             = $::os_service_default,
-  # DEPRECATED PARAMETERS
-  $validate                         = undef,
 ) inherits neutron::params {
 
   include neutron::deps
   include neutron::db
   include neutron::policy
 
-  if $validate != undef {
-    warning('The neutron::server::validate parameter has been deprecated and has no effect')
-  }
-
   if !is_service_default($default_availability_zones) {
     validate_legacy(Array, 'validate_array', $default_availability_zones)
   }
diff --git a/releasenotes/notes/remove-service-validation-ea042dda42e67fd4.yaml b/releasenotes/notes/remove-service-validation-ea042dda42e67fd4.yaml
new file mode 100644
index 000000000..4a9f75b56
--- /dev/null
+++ b/releasenotes/notes/remove-service-validation-ea042dda42e67fd4.yaml
@@ -0,0 +1,4 @@
+---
+upgrade:
+  - |
+    The ``neutron::server::validate`` parameter has been removed.