390 lines
14 KiB
Ruby
390 lines
14 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'neutron::agents::ml2::ovs' do
|
|
let :pre_condition do
|
|
"class { 'neutron': }"
|
|
end
|
|
|
|
let :default_params do
|
|
{ :package_ensure => 'present',
|
|
:enabled => true,
|
|
:bridge_uplinks => [],
|
|
:bridge_mappings => [],
|
|
:integration_bridge => 'br-int',
|
|
:local_ip => false,
|
|
:tunnel_types => [],
|
|
:tunnel_bridge => 'br-tun',
|
|
:drop_flows_on_start => false,
|
|
:firewall_driver => 'iptables_hybrid',
|
|
:manage_vswitch => true,
|
|
:purge_config => false,
|
|
:enable_dpdk => false,
|
|
}
|
|
end
|
|
|
|
let :params do
|
|
{}
|
|
end
|
|
|
|
shared_examples 'neutron plugin ovs agent with ml2 plugin' do
|
|
let :p do
|
|
default_params.merge(params)
|
|
end
|
|
|
|
it { should contain_class('neutron::params') }
|
|
|
|
it 'passes purge to resource' do
|
|
should contain_resources('neutron_agent_ovs').with({
|
|
:purge => false
|
|
})
|
|
end
|
|
|
|
it 'configures plugins/ml2/openvswitch_agent.ini' do
|
|
should contain_neutron_agent_ovs('agent/polling_interval').with_value('<SERVICE DEFAULT>')
|
|
should contain_neutron_agent_ovs('agent/l2_population').with_value('<SERVICE DEFAULT>')
|
|
should contain_neutron_agent_ovs('agent/arp_responder').with_value('<SERVICE DEFAULT>')
|
|
should contain_neutron_agent_ovs('agent/drop_flows_on_start').with_value(p[:drop_flows_on_start])
|
|
should contain_neutron_agent_ovs('agent/extensions').with_value(['<SERVICE DEFAULT>'])
|
|
should contain_neutron_agent_ovs('agent/minimize_polling').with_value(['<SERVICE DEFAULT>'])
|
|
should contain_neutron_agent_ovs('agent/tunnel_csum').with_value(['<SERVICE DEFAULT>'])
|
|
should contain_neutron_agent_ovs('ovs/datapath_type').with_value(['<SERVICE DEFAULT>'])
|
|
should contain_neutron_agent_ovs('ovs/vhostuser_socket_dir').with_value(['<SERVICE DEFAULT>'])
|
|
should contain_neutron_agent_ovs('ovs/ovsdb_interface').with_value(['<SERVICE DEFAULT>'])
|
|
should contain_neutron_agent_ovs('ovs/ovsdb_timeout').with_value('<SERVICE DEFAULT>')
|
|
should contain_neutron_agent_ovs('ovs/of_inactivity_probe').with_value('<SERVICE DEFAULT>')
|
|
should contain_neutron_agent_ovs('ovs/integration_bridge').with_value(p[:integration_bridge])
|
|
should contain_neutron_agent_ovs('securitygroup/firewall_driver').\
|
|
with_value(p[:firewall_driver])
|
|
should contain_neutron_agent_ovs('securitygroup/enable_security_group').\
|
|
with_value(['<SERVICE DEFAULT>'])
|
|
should_not contain_neutron_agent_ovs('securitygroup/permitted_ethertypes')
|
|
should contain_neutron_agent_ovs('ovs/tunnel_bridge').with_ensure('absent')
|
|
should contain_neutron_agent_ovs('ovs/local_ip').with_ensure('absent')
|
|
should contain_neutron_agent_ovs('ovs/int_peer_patch_port').with_ensure('absent')
|
|
should contain_neutron_agent_ovs('ovs/tun_peer_patch_port').with_ensure('absent')
|
|
should contain_neutron_agent_ovs('agent/tunnel_types').with_ensure('absent')
|
|
end
|
|
|
|
it 'installs neutron ovs agent package' do
|
|
if platform_params.has_key?(:ovs_agent_package)
|
|
should contain_package('neutron-ovs-agent').with(
|
|
:name => platform_params[:ovs_agent_package],
|
|
:ensure => p[:package_ensure],
|
|
:tag => ['openstack', 'neutron-package'],
|
|
)
|
|
else
|
|
end
|
|
end
|
|
|
|
it 'configures neutron ovs agent service' do
|
|
should contain_service('neutron-ovs-agent-service').with(
|
|
:name => platform_params[:ovs_agent_service],
|
|
:enable => true,
|
|
:ensure => 'running',
|
|
:tag => ['neutron-service', 'neutron-db-sync-service'],
|
|
)
|
|
should contain_service('neutron-ovs-agent-service').that_subscribes_to('Anchor[neutron::service::begin]')
|
|
should contain_service('neutron-ovs-agent-service').that_notifies('Anchor[neutron::service::end]')
|
|
end
|
|
|
|
context 'with manage_service as false' do
|
|
before :each do
|
|
params.merge!(:manage_service => false)
|
|
end
|
|
it 'should not start/stop service' do
|
|
should contain_service('neutron-ovs-agent-service').without_ensure
|
|
end
|
|
end
|
|
|
|
context 'when supplying permitted ethertypes' do
|
|
before :each do
|
|
params.merge!(:permitted_ethertypes => ['0x4008', '0x5'])
|
|
end
|
|
it 'should configured ethertypes' do
|
|
should contain_neutron_agent_ovs('securitygroup/permitted_ethertypes').with_value('0x4008,0x5')
|
|
end
|
|
end
|
|
|
|
context 'when supplying a firewall driver' do
|
|
before :each do
|
|
params.merge!(:firewall_driver => false)
|
|
end
|
|
it 'should configure firewall driver' do
|
|
should contain_neutron_agent_ovs('securitygroup/firewall_driver').with_ensure('absent')
|
|
end
|
|
end
|
|
|
|
context 'when disabling security groups' do
|
|
before :each do
|
|
params.merge!(:enable_security_group => false)
|
|
end
|
|
it 'should disable securitygroups' do
|
|
should contain_neutron_agent_ovs('securitygroup/enable_security_group').with_value('false')
|
|
end
|
|
end
|
|
|
|
|
|
context 'when enabling ARP responder' do
|
|
before :each do
|
|
params.merge!(:arp_responder => true)
|
|
end
|
|
it 'should enable ARP responder' do
|
|
should contain_neutron_agent_ovs('agent/arp_responder').with_value(true)
|
|
end
|
|
end
|
|
|
|
context 'when enabling DVR' do
|
|
before :each do
|
|
params.merge!(:enable_distributed_routing => true,
|
|
:l2_population => true )
|
|
end
|
|
it 'should enable DVR' do
|
|
should contain_neutron_agent_ovs('agent/enable_distributed_routing').with_value(true)
|
|
end
|
|
end
|
|
|
|
context 'when supplying bridge mappings for provider networks' do
|
|
before :each do
|
|
params.merge!(:bridge_uplinks => ['br-ex:eth2'],:bridge_mappings => ['default:br-ex'])
|
|
end
|
|
|
|
it 'should require vswitch::ovs' do
|
|
should contain_class('vswitch::ovs')
|
|
end
|
|
|
|
it 'configures bridge mappings' do
|
|
should contain_neutron_agent_ovs('ovs/bridge_mappings')
|
|
end
|
|
|
|
it 'should configure bridge mappings' do
|
|
should contain_neutron__plugins__ovs__bridge(params[:bridge_mappings].join(',')).with(
|
|
:before => 'Service[neutron-ovs-agent-service]'
|
|
)
|
|
end
|
|
|
|
it 'should configure bridge uplinks' do
|
|
should contain_neutron__plugins__ovs__port(params[:bridge_uplinks].join(',')).with(
|
|
:before => 'Service[neutron-ovs-agent-service]'
|
|
)
|
|
end
|
|
end
|
|
|
|
context 'when supplying bridge mappings for provider networks with manage vswitch set to false' do
|
|
before :each do
|
|
params.merge!(:bridge_uplinks => ['br-ex:eth2'],:bridge_mappings => ['default:br-ex'], :manage_vswitch => false)
|
|
end
|
|
|
|
it 'should not require vswitch::ovs' do
|
|
should_not contain_class('vswitch::ovs')
|
|
end
|
|
|
|
it 'configures bridge mappings' do
|
|
should contain_neutron_agent_ovs('ovs/bridge_mappings')
|
|
end
|
|
|
|
it 'should not configure bridge mappings' do
|
|
should_not contain_neutron__plugins__ovs__bridge(params[:bridge_mappings].join(',')).with(
|
|
:before => 'Service[neutron-ovs-agent-service]'
|
|
)
|
|
end
|
|
|
|
it 'should not configure bridge uplinks' do
|
|
should_not contain_neutron__plugins__ovs__port(params[:bridge_uplinks].join(',')).with(
|
|
:before => 'Service[neutron-ovs-agent-service]'
|
|
)
|
|
end
|
|
end
|
|
|
|
context 'when setting ovsdb_timeout' do
|
|
before :each do
|
|
params.merge!( :ovsdb_timeout => 30 )
|
|
end
|
|
|
|
it 'configures ovsdb_timeout' do
|
|
should contain_neutron_agent_ovs('ovs/ovsdb_timeout').with_value(params[:ovsdb_timeout])
|
|
end
|
|
end
|
|
|
|
context 'when setting of_inactivity_probe' do
|
|
before :each do
|
|
params.merge!( :of_inactivity_probe => 20 )
|
|
end
|
|
|
|
it 'configures of_inactivity_probe' do
|
|
should contain_neutron_agent_ovs('ovs/of_inactivity_probe').with_value(params[:of_inactivity_probe])
|
|
end
|
|
end
|
|
|
|
context 'when supplying extensions for ML2 plugin' do
|
|
before :each do
|
|
params.merge!(:extensions => ['qos'])
|
|
end
|
|
|
|
it 'configures extensions' do
|
|
should contain_neutron_agent_ovs('agent/extensions').with_value(params[:extensions].join(','))
|
|
end
|
|
end
|
|
|
|
context 'when supplying DPDK specific options' do
|
|
before :each do
|
|
params.merge!(:datapath_type => 'netdev', :vhostuser_socket_dir => '/var/run/openvswitch')
|
|
end
|
|
|
|
it 'configures ovs for DPDK' do
|
|
should contain_neutron_agent_ovs('ovs/datapath_type').with_value(params[:datapath_type])
|
|
should contain_neutron_agent_ovs('ovs/vhostuser_socket_dir').with_value(params[:vhostuser_socket_dir])
|
|
end
|
|
end
|
|
|
|
context 'when enabling tunneling' do
|
|
context 'without local ip address' do
|
|
before :each do
|
|
params.merge!(:tunnel_types => ['vxlan'])
|
|
end
|
|
|
|
it { should raise_error(Puppet::Error, /Local ip for ovs agent must be set when tunneling is enabled/) }
|
|
end
|
|
context 'with default params' do
|
|
before :each do
|
|
params.merge!(:tunnel_types => ['vxlan'], :local_ip => '127.0.0.1' )
|
|
end
|
|
it 'should configure ovs for tunneling' do
|
|
should contain_neutron_agent_ovs('ovs/tunnel_bridge').with_value(default_params[:tunnel_bridge])
|
|
should contain_neutron_agent_ovs('ovs/local_ip').with_value('127.0.0.1')
|
|
should contain_neutron_agent_ovs('ovs/int_peer_patch_port').with_value('<SERVICE DEFAULT>')
|
|
should contain_neutron_agent_ovs('ovs/tun_peer_patch_port').with_value('<SERVICE DEFAULT>')
|
|
end
|
|
end
|
|
|
|
context 'with vxlan tunneling' do
|
|
before :each do
|
|
params.merge!(:local_ip => '127.0.0.1',
|
|
:tunnel_types => ['vxlan'],
|
|
:vxlan_udp_port => '4789')
|
|
end
|
|
|
|
it 'should perform vxlan network configuration' do
|
|
should contain_neutron_agent_ovs('agent/tunnel_types').with_value(params[:tunnel_types])
|
|
should contain_neutron_agent_ovs('agent/vxlan_udp_port').with_value(params[:vxlan_udp_port])
|
|
end
|
|
end
|
|
|
|
context 'when l2 population is disabled and DVR and tunneling enabled' do
|
|
before :each do
|
|
params.merge!(:enable_distributed_routing => true,
|
|
:l2_population => false,
|
|
:tunnel_types => ['vxlan'],
|
|
:local_ip => '127.0.0.1' )
|
|
end
|
|
|
|
it { should raise_error(Puppet::Error, /L2 population must be enabled when DVR and tunneling are enabled/) }
|
|
end
|
|
|
|
context 'when DVR is enabled and l2 population and tunneling are disabled' do
|
|
before :each do
|
|
params.merge!(:enable_distributed_routing => true,
|
|
:l2_population => false,
|
|
:tunnel_types => [] )
|
|
end
|
|
|
|
it 'should enable DVR without L2 population' do
|
|
should contain_neutron_agent_ovs('agent/enable_distributed_routing').with_value(true)
|
|
should contain_neutron_agent_ovs('agent/l2_population').with_value(false)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when supplying ovsdb_interface' do
|
|
context 'with incorrect value' do
|
|
before :each do
|
|
params.merge!(:ovsdb_interface => 'random')
|
|
end
|
|
|
|
it { should raise_error(Puppet::Error, /A value of \$ovsdb_interface is incorrect. The allowed values are vsctl and native/) }
|
|
end
|
|
|
|
context 'with supported value' do
|
|
before :each do
|
|
params.merge!(:ovsdb_interface => 'native')
|
|
end
|
|
it 'should configure ovsdb_interface for ovs' do
|
|
should contain_neutron_agent_ovs('ovs/ovsdb_interface').with_value('native')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when enabling dpdk with manage vswitch disabled' do
|
|
before :each do
|
|
params.merge!(:enable_dpdk => true, :manage_vswitch => false)
|
|
end
|
|
|
|
it { should raise_error(Puppet::Error, /Enabling DPDK without manage vswitch does not have any effect/) }
|
|
end
|
|
end
|
|
|
|
shared_examples 'neutron::agents::ml2::ovs on Debian' do
|
|
# placeholder for debian specific tests
|
|
end
|
|
|
|
shared_examples 'neutron::agents::ml2::ovs on RedHat' do
|
|
it 'configures neutron ovs cleanup service' do
|
|
should contain_service('ovs-cleanup-service').with(
|
|
:name => platform_params[:ovs_cleanup_service],
|
|
:enable => true
|
|
).that_requires('Anchor[neutron::install::end]')
|
|
should contain_package('neutron-ovs-agent').that_requires('Anchor[neutron::install::begin]')
|
|
should contain_package('neutron-ovs-agent').that_notifies('Anchor[neutron::install::end]')
|
|
end
|
|
|
|
it 'configures neutron destroy patch ports service' do
|
|
should contain_service('neutron-destroy-patch-ports-service').with(
|
|
:name => platform_params[:destroy_patch_ports_service],
|
|
:enable => true,
|
|
:ensure => 'running',
|
|
:tag => ['neutron-service'],
|
|
)
|
|
end
|
|
|
|
context 'when enabling dpdk with manage vswitch is default' do
|
|
let :pre_condition do
|
|
"class { 'vswitch::dpdk': host_core_list => '1,2', memory_channels => '1' }"
|
|
end
|
|
before :each do
|
|
params.merge!(:enable_dpdk => true,
|
|
:datapath_type => 'netdev',
|
|
:vhostuser_socket_dir => '/var/run/openvswitch')
|
|
end
|
|
|
|
it 'should require vswitch::dpdk' do
|
|
should contain_class('vswitch::dpdk')
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
on_supported_os({
|
|
:supported_os => OSDefaults.get_supported_os
|
|
}).each do |os,facts|
|
|
context "on #{os}" do
|
|
let (:facts) do
|
|
facts.merge!(OSDefaults.get_facts())
|
|
end
|
|
|
|
let (:platform_params) do
|
|
case facts[:osfamily]
|
|
when 'Debian'
|
|
{ :ovs_agent_package => 'neutron-openvswitch-agent',
|
|
:ovs_agent_service => 'neutron-openvswitch-agent' }
|
|
when 'RedHat'
|
|
{ :ovs_cleanup_service => 'neutron-ovs-cleanup',
|
|
:ovs_agent_service => 'neutron-openvswitch-agent',
|
|
:destroy_patch_ports_service => 'neutron-destroy-patch-ports' }
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'neutron plugin ovs agent with ml2 plugin'
|
|
it_behaves_like "neutron::agents::ml2::ovs on #{facts[:osfamily]}"
|
|
end
|
|
end
|
|
end
|