openstack/puppet-nova
Code Issues Proposed changes

Replace redundant hard-code of [libvirt] inject_*

Browse Source 
The current default values are same as the defaults defined in Nova,
thus can be replaced by $::os_service_default .

Change-Id: I723215afe7ba085f3da993189d9e2db85c1fa2aa
This commit is contained in:
Takashi Kajinami 2022-09-04 22:55:32 +09:00
parent ba583fadf4
commit 02072d7e2a
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
manifests/compute/libvirt.pp
View File

@ -71,17 +71,17 @@
#
# [*inject_password*]
# (optional) Inject the admin password at boot time, without an agent.
# Defaults to false
# Defaults to $::os_service_default
#
# [*inject_key*]
# (optional) Inject the ssh public key at boot time.
# Defaults to false
# Defaults to $::os_service_default
#
# [*inject_partition*]
# (optional) The partition to inject to : -2 => disable, -1 => inspect
# (libguestfs only), 0 => not partitioned, >0 => partition
# number (integer value)
# Defaults to -2
# Defaults to $::os_service_default
#
# [*enabled_perf_events*]
# (optional) This is a performance event list which could be used as monitor.
@ -249,9 +249,9 @@ class nova::compute::libvirt (
$hw_disk_discard = $::os_service_default,
$hw_machine_type = $::os_service_default,
$sysinfo_serial = $::os_service_default,
$inject_password = false,
$inject_key = false,
$inject_partition = -2,
$inject_password = $::os_service_default,
$inject_key = $::os_service_default,
$inject_partition = $::os_service_default,
$enabled_perf_events = $::os_service_default,
$device_detach_attempts = $::os_service_default,
$device_detach_timeout = $::os_service_default,

12
spec/classes/nova_compute_libvirt_spec.rb
View File

@ -54,9 +54,9 @@ describe 'nova::compute::libvirt' do
it { is_expected.to contain_nova_config('libvirt/snapshot_image_format').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/snapshots_directory').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/disk_cachemodes').with_ensure('absent')}
it { is_expected.to contain_nova_config('libvirt/inject_password').with_value(false)}
it { is_expected.to contain_nova_config('libvirt/inject_key').with_value(false)}
it { is_expected.to contain_nova_config('libvirt/inject_partition').with_value(-2)}
it { is_expected.to contain_nova_config('libvirt/inject_password').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/inject_key').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/inject_partition').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/enabled_perf_events').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/sysinfo_serial').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/device_detach_attempts').with_value('<SERVICE DEFAULT>')}
@ -273,9 +273,9 @@ describe 'nova::compute::libvirt' do
it { is_expected.to contain_nova_config('DEFAULT/compute_driver').with_value('libvirt.LibvirtDriver')}
it { is_expected.to contain_nova_config('libvirt/virt_type').with_value('kvm')}
it { is_expected.to contain_nova_config('libvirt/inject_password').with_value(false)}
it { is_expected.to contain_nova_config('libvirt/inject_key').with_value(false)}
it { is_expected.to contain_nova_config('libvirt/inject_partition').with_value(-2)}
it { is_expected.to contain_nova_config('libvirt/inject_password').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/inject_key').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/inject_partition').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('vnc/server_listen').with_value('127.0.0.1')}
it { is_expected.to contain_nova_config('libvirt/enabled_perf_events').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/device_detach_attempts').with_value('<SERVICE DEFAULT>')}