openstack/puppet-nova
Code Issues Proposed changes

Purge [vnc] novncproxy_base_url by default

Browse Source 
... to avoid leaving an unmanaged value.

Change-Id: I9d2c3feaca241959fec6b20a386542e91c280e6a
This commit is contained in:
Takashi Kajinami 2025-04-26 23:53:42 +09:00
parent a284d01e0a
commit 0f02bab8b6
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/vncproxy/common.pp
View File

@ -103,5 +103,9 @@ class nova::vncproxy::common (
nova_config {
'vnc/novncproxy_base_url': value => $vncproxy_base_url;
}
} else {
nova_config {
'vnc/novncproxy_base_url': value => $facts['os_service_default'];
}
}
}

2
spec/classes/nova_compute_spec.rb
View File

@ -26,8 +26,8 @@ describe 'nova::compute' do
it 'does not configure vncproxy base url in nova.conf' do
is_expected.to contain_nova_config('vnc/enabled').with_value(true)
is_expected.to_not contain_nova_config('vnc/novncproxy_base_url')
is_expected.to contain_nova_config('vnc/server_proxyclient_address').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('vnc/novncproxy_base_url').with_value('<SERVICE DEFAULT>')
end
it 'should have spice disabled' do