openstack
/
puppet-nova
Code Issues Proposed changes

Remove usage of deleted manifest_dir 

Recent update in rspec-puppet removed some of the config interfaces for
old puppet versions[1]. This drops usage of these interfaces to resolve
the following error in unit tests.

```
An error occurred while loading ./spec/unit/provider/manila_spec.rb.
Failure/Error: c.manifest_dir = File.join(fixture_path, 'manifests')

NoMethodError:
  undefined method `manifest_dir='...
```

This also removes explicit setting of mock module. The definition is
no longer required since we bumped puppetlabs_spec_helper to v 5.0.0.

[1] 316d95923c

Change-Id: I0e133a13ff3b751ee5bf9f99495b82073f0c6971
This commit is contained in:
Takashi Kajinami 2023-10-11 12:04:17 +09:00
parent 2a1bd2bc34
commit 14a1cc5a61
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
spec/spec_helper.rb
View File

@ -13,9 +13,6 @@ RSpec.configure do |c|
c.alias_it_should_behave_like_to :it_raises, 'raises'
c.module_path = File.join(fixture_path, 'modules')
c.manifest_dir = File.join(fixture_path, 'manifests')
c.mock_with :rspec
end
at_exit { RSpec::Puppet::Coverage.report! }